You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/13 18:50:46 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2523: Fix Redundant ScalarValue Boxed Collection

tustvold commented on code in PR #2523:
URL: https://github.com/apache/arrow-datafusion/pull/2523#discussion_r872692149


##########
datafusion/common/src/scalar.rs:
##########
@@ -74,8 +74,7 @@ pub enum ScalarValue {
     /// large binary
     LargeBinary(Option<Vec<u8>>),
     /// list of nested ScalarValue (boxed to reduce size_of(ScalarValue))
-    #[allow(clippy::box_collection)]
-    List(Option<Box<Vec<ScalarValue>>>, Box<DataType>),
+    List(Option<Vec<ScalarValue>>, DataType),

Review Comment:
   I'm not sure about unboxing DataType here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org