You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/11/15 10:46:39 UTC

[GitHub] [mynewt-nimble] haukepetersen commented on issue #650: host/l2cap_coc: fix receiving of frames with size 1

haukepetersen commented on issue #650: host/l2cap_coc: fix receiving of frames with size 1
URL: https://github.com/apache/mynewt-nimble/pull/650#issuecomment-554311269
 
 
   btw, could you enlighten me what the `pullup()` call does in particular? As far as I understood, it makes sure that all data in a mbuf chain is moved so that it resides continuously at the beginning of the chain and thereby using the optimal number of mbufs, right?!
   
   But looking at the way the data is received in  the l2cap layer, it seems to me that the this is always the case already when entering the `ble_l2cap_coc_rx_fn()` function. So would it maybe make sense to remove the `pullup()` call all together?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services