You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/04/30 00:41:07 UTC
[jira] [Commented] (HADOOP-11104)
org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520433#comment-14520433 ]
Hadoop QA commented on HADOOP-11104:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 32s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 7m 47s | The applied patch generated 1 additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 37s | Tests passed in hadoop-common. |
| | | 67m 12s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2e21548 |
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/whitespace.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/checkstyle-result-diff.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/console |
This message was automatically generated.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Priority: Minor
> Labels: BB2015-05-TBR, newbie
> Attachments: HADOOP-11104.001.patch
>
>
> Passing a negative value to the interval field of MetricsRegistry#newQuantiles should throw a MetricsException with a clear error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
> at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like MetricsRegistry#newCounter() also have parameter checking for negative int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)