You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/08 23:15:10 UTC

[jclouds-labs-google] Remove creepy and unused extensibility. (#87)

optional injection is one of the scariest things in guice. we have not needed these extension points in 2 years, so I&#39;m guessing we can kill them.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-google adrian.oauth-again

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/87

-- Commit Summary --

  * Remove creepy and unused extensibility.

-- File Changes --

    M oauth/README (4)
    M oauth/src/main/java/org/jclouds/oauth/v2/OAuthConstants.java (14)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthProperties.java (9)
    M oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthScopes.java (8)
    M oauth/src/main/java/org/jclouds/oauth/v2/filters/OAuthAuthenticationFilter.java (5)
    M oauth/src/main/java/org/jclouds/oauth/v2/functions/BuildTokenRequest.java (36)
    M oauth/src/test/java/org/jclouds/oauth/v2/features/OAuthApiLiveTest.java (4)
    M oauth/src/test/java/org/jclouds/oauth/v2/features/OAuthApiMockTest.java (8)
    M oauth/src/test/java/org/jclouds/oauth/v2/internal/BaseOAuthApiLiveTest.java (3)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/87.patch
https://github.com/jclouds/jclouds-labs-google/pull/87.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by Adrian Cole <no...@github.com>.
> @@ -116,7 +116,8 @@ protected BaseGoogleComputeEngineExpectTest() {
>           @Override
>           public void configure(Binder binder) {
>              // Predictable time
> -            binder.bind(new TypeLiteral<Supplier<Long>>() {}).toInstance(Suppliers.ofInstance(0L));
> +            binder.bind(BuildTokenRequest.class).to(BuildTokenRequest.WithConstantIssuedAt.class);

@ccustine not sure if you are using this in your DO tests or not. For example, the new tests I'm writing are using bearer token. At any rate.. heads-up.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87/files#r20056678

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by Adrian Cole <no...@github.com>.
@ccustine 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62280979

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by Adrian Cole <no...@github.com>.
I'll address this after reworking oauth annotations.. I think.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62419227

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #257](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/257/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62281040

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1671](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1671/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62281376

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1672](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1672/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62291602

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #259](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/259/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62291498

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1670](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1670/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62281174

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #258](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/258/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#issuecomment-62281223

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by Adrian Cole <no...@github.com>.
Closed #87.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87#event-192463355

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by Adrian Cole <no...@github.com>.
> @@ -67,12 +61,6 @@
>             .put("ES512", "EC")
>             .put(NO_ALGORITHM, NO_ALGORITHM).build();
>  
> -   /**
> -    * The (optional) set of additional claims to use, provided in Map<String,String> form
> -    */

only used in tests, and only in this module

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87/files#r20054880

Re: [jclouds-labs-google] Remove creepy and unused extensibility. (#87)

Posted by Adrian Cole <no...@github.com>.
>  public final class BuildTokenRequest implements Function<GeneratedHttpRequest, TokenRequest> {
>     private final String assertionTargetDescription;
>     private final String signatureAlgorithm;
>     private final Supplier<OAuthCredentials> credentialsSupplier;
>     private final long tokenDuration;
>  
> -   @Inject(optional = true)
> -   @Named(ADDITIONAL_CLAIMS)
> -   private Map<String, String> additionalClaims = Collections.emptyMap();
> -
> -   @Inject(optional = true)
> -   @Named(SCOPES)
> -   private String globalScopes = null;
> -
> -   // injectable so expect tests can override with a predictable value

I love how we say things like I'm doing this for tests, yet not actually write them!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/87/files#r20054860