You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/22 15:20:00 UTC
[GitHub] [activemq-artemis] emagiz opened a new pull request #3196: Stop the timeout future when channel is closed
emagiz opened a new pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196
Solves a small issue we are having with the AWS load balancer doing a health check. The logging explodes with warnings I think.
The cause is that there is no event handling the graceful closure of a connection. This fix should solve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3196: Stop the timeout future when channel is closed
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196#issuecomment-648119126
what's the reason behind this? What failures did you see for this?
is it possible to include a test?
Also: the commit-id needs to be ammended with a JIRA:
``ARTEMIS-XXX Stop the timeout future when channel is closed``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3196: Stop the timeout future when channel is closed
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196#issuecomment-648887276
This is a nice little fix. It eliminates the false positives we get for clients (e.g. load balancer health-checkers ) that connect to an acceptor, don't complete a protocol handshake, but still close their connection. Previously we recommended a configuration change to work-around it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3196: Stop the timeout future when channel is closed
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196#issuecomment-648252322
@emagiz The full testsuite pass... I just wanted to confirm what failing scenario did you see with this as this requires a JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram edited a comment on pull request #3196: Stop the timeout future when channel is closed
Posted by GitBox <gi...@apache.org>.
jbertram edited a comment on pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196#issuecomment-648887276
@clebertsuconic, this is a nice little fix. It eliminates the false positives we get for clients (e.g. load balancer health-checkers ) that connect to an acceptor, don't complete a protocol handshake, but still close their connection. Previously we recommended a configuration change to work-around it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3196: Stop the timeout future when channel is closed
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] emagiz commented on pull request #3196: Stop the timeout future when channel is closed
Posted by GitBox <gi...@apache.org>.
emagiz commented on pull request #3196:
URL: https://github.com/apache/activemq-artemis/pull/3196#issuecomment-648745862
Sure, I'll create a JIRA because I don't have one right now. I can amend the commit and include the JIRA issue when I create it. Can I keep the JIRA issue short as I probably don't have the logging anymore. Basically the scheduled future is not canceled on gracefull close and we have a log statement per port check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org