You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 01:13:08 UTC
[I] [BUG] DiscoveryUpstreamDataHandler.doRefresh() (WebSocket) does not call refresh() before re-adding data [shenyu]
Aias00 opened a new issue, #6782:
URL: https://github.com/apache/shenyu/issues/6782
- Severity: Medium
- Location:
`shenyu-sync-data-center/shenyu-sync-data-websocket/src/main/java/org/apache/shenyu/plugin/sync/data/websocket/handler/DiscoveryUpstreamDataHandler.java:40-42`
-
Description:
`doRefresh` directly calls `data.forEach(... onSubscribe)` without first calling `refresh()` on subscribers. `AuthDataHandler.doRefresh()` (line 43: `authDataSubscribers.forEach(AuthDataSubscriber::refresh)`) and `ProxySelectorDataHandler.doRefresh()` (line 45) both clear stale data first then re-add. `DiscoveryUpstreamDataHandler` is the only handler that skips the clear step.
-
Impact:
On a WebSocket REFRESH event for discovery upstreams, stale upstream data is not cleared before new data is added; old discovery entries no longer present in the refresh payload persist.
-
Suggested fix:
Add `discoveryUpstreamDataSubscribers.forEach(DiscoveryUpstreamDataSubscriber::refresh)` as the first line of `doRefresh`, matching `AuthDataHandler` and `ProxySelectorDataHandler`.
-
Confidence: High
---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] DiscoveryUpstreamDataHandler.doRefresh() (WebSocket) does not call refresh() before re-adding data [shenyu]
Posted by "yykaue (via GitHub)" <gi...@apache.org>.
yykaue commented on issue #6782:
URL: https://github.com/apache/shenyu/issues/6782#issuecomment-5367543109
/assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] DiscoveryUpstreamDataHandler.doRefresh() (WebSocket) does not call refresh() before re-adding data [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6782: [BUG] DiscoveryUpstreamDataHandler.doRefresh() (WebSocket) does not call refresh() before re-adding data
URL: https://github.com/apache/shenyu/issues/6782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] DiscoveryUpstreamDataHandler.doRefresh() (WebSocket) does not call refresh() before re-adding data [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6782:
URL: https://github.com/apache/shenyu/issues/6782#issuecomment-5161319118
👋 Hello @Aias00
A new issue has been opened by @Aias00:
- **Title**: [BUG] DiscoveryUpstreamDataHandler.doRefresh() (WebSocket) does not call refresh() before re-adding data
- **Link**: https://github.com/apache/shenyu/issues/6782
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org