You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/31 06:05:57 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #666: Separate
workflow into a few files
yamt opened a new pull request #666: Separate workflow into a few files
URL: https://github.com/apache/incubator-nuttx/pull/666
To make it simpler to sync with testing repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #666: CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400876028
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
> also, i'm not sure if build.yml is a better name. i guess we want to add a job to run eg. sim ostest sooner or later.
call it run.xml or test.xml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #666: CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400689174
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
Should we change line 13 to:
name: PR Check CI (build)
and rename main.yml to build.yml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #666: CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400960310
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
Should we name it build.xml? there isn't test at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #666:
CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400970362
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
i wanted to save another rename. but i changed it to build.xml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #666: CI:
Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #666:
CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400907812
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
do you mean to have separate build.xml and test.xml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #666: CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400914555
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
> do you mean to have separate build.xml and test.xml?
Maybe, if we can express the dependence across the yaml files, otherwise we need to stick into one yaml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #666:
CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400954130
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
see https://github.com/apache/incubator-nuttx-testing/pull/25
i will update this and apps once the testing one is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #666:
CI: Tweak workflow to make it simpler to sync with other repos
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #666: CI: Tweak workflow to make it simpler to sync with other repos
URL: https://github.com/apache/incubator-nuttx/pull/666#discussion_r400691446
##########
File path: .github/workflows/main.yml
##########
@@ -16,47 +16,6 @@ on:
pull_request:
jobs:
- check:
Review comment:
i want to make this sync with testing repo's main.yml for now.
maybe we can change it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services