[GitHub] yajiedesign commented on a change in pull request #8967: add shared storage in windows

[GitBox <gi...@apache.org>]

yajiedesign commented on a change in pull request #8967: add shared storage in windows
URL: https://github.com/apache/incubator-mxnet/pull/8967#discussion_r155397217
 
 

 ##########
 File path: src/storage/cpu_shared_storage_manager.h
 ##########
 @@ -91,11 +95,18 @@ class CPUSharedStorageManager final : public StorageManager {
  private:
   static constexpr size_t alignment_ = 16;
 
-  std::mutex mutex_;
+  std::recursive_mutex mutex_;
   std::mt19937 rand_gen_;
-  std::unordered_map<void*, Storage::Handle> pool_;
+  std::unordered_map<void*, Storage::Handle> pool_; 
+#ifdef _WIN32
+  std::unordered_map<void*, Storage::Handle> is_free_;
+  std::unordered_map<void*, HANDLE> map_handle_map_;
 
 Review comment:
   only use pool_ has the problem of repeated release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services