[GitHub] [incubator-superset] rusackas commented on pull request #12153: fix: Add visibility to box for viewing menu items

[GitBox <gi...@apache.org>]

rusackas commented on pull request #12153:
URL: https://github.com/apache/incubator-superset/pull/12153#issuecomment-754470698


   > This PR fixes the original issue but it seems introduce 2 critical issues below.
   > @maloun96 please take another look, thanks!
   > 
   > 1. can not resize filter box individually, it drags the chart near by as resizing
   > 
   >  Screen.Recording.2021-01-04.at.10.07.25.PM.mov 
   > 1. all other charts(not filter box)can not be resized at all.
   > 
   >  Screen.Recording.2021-01-04.at.10.07.41.PM.mov
   
   I believe issue #1 is due to the two charts being part of a "Column" and you're resizing that column. If I take them out of the column, they resize individually just fine.
   
   I also see #2, but I also see it on `master`. Interestingly, the resize cursor on the right edge doesn't show, but if you try the bottom right hand corner, you'll see the diagonal resize cursor, and it works just fine.
   
   Therefore, I'm approving this PR, but will hold off from merging without your thumbs up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org