You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/05/23 08:29:05 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24185: fix: db validate parameters permission
dpgaspar opened a new pull request, #24185:
URL: https://github.com/apache/superset/pull/24185
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24185: fix: db validate parameters permission
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24185:
URL: https://github.com/apache/superset/pull/24185#issuecomment-1559962405
@dpgaspar Can you add a note in the Breaking Changes section about this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24185: fix: db validate parameters permission
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24185:
URL: https://github.com/apache/superset/pull/24185#issuecomment-1558812203
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24185](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e9bc5e9) into [master](https://app.codecov.io/gh/apache/superset/commit/82d4249e17fd2f9e0af772dca92403647b9cfef0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (82d4249) will **decrease** coverage by `11.20%`.
> The diff coverage is `89.34%`.
> :exclamation: Current head e9bc5e9 differs from pull request most recent head a76cfa5. Consider uploading reports for the commit a76cfa5 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24185 +/- ##
===========================================
- Coverage 68.25% 57.06% -11.20%
===========================================
Files 1955 1955
Lines 75405 75498 +93
Branches 8215 8220 +5
===========================================
- Hits 51471 43082 -8389
- Misses 21828 30309 +8481
- Partials 2106 2107 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.27% <71.92%> (+0.04%)` | :arrow_up: |
| python | `59.60% <89.47%> (-23.22%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.38% <89.47%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...end/src/features/databases/DatabaseModal/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `43.63% <ø> (ø)` | |
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `51.02% <ø> (-35.08%)` | :arrow_down: |
| [superset/constants.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/dashboards/permalink/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvY29tbWFuZHMvY3JlYXRlLnB5) | `48.38% <33.33%> (-44.48%)` | :arrow_down: |
| [superset/explore/permalink/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXhwbG9yZS9wZXJtYWxpbmsvY29tbWFuZHMvY3JlYXRlLnB5) | `41.66% <33.33%> (-49.25%)` | :arrow_down: |
| [superset/datasets/schemas.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `97.48% <50.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/hooks.ts](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `53.14% <66.66%> (+0.19%)` | :arrow_up: |
| [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `52.16% <76.92%> (-39.40%)` | :arrow_down: |
| [superset/key\_value/types.py](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQva2V5X3ZhbHVlL3R5cGVzLnB5) | `90.62% <84.00%> (-4.50%)` | :arrow_down: |
| [...tend/src/components/Datasource/DatasourceModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlTW9kYWwudHN4) | `74.00% <100.00%> (+0.53%)` | :arrow_up: |
| ... and [14 more](https://app.codecov.io/gh/apache/superset/pull/24185?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24185/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24185: fix: db validate parameters permission
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24185:
URL: https://github.com/apache/superset/pull/24185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #24185: fix: db validate parameters permission
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on PR #24185:
URL: https://github.com/apache/superset/pull/24185#issuecomment-1559690291
> Do we need to update any of the tests? Or add a new one?
Good point! probably a test to make sure Gamma user's don't access these. I'll add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24185: fix: db validate parameters permission
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24185:
URL: https://github.com/apache/superset/pull/24185#issuecomment-1559835983
@dpgaspar I understand that from the application's perspective these API will be called from features that require `write` permissions but if we look from the API perspective, they could be called by users with `read` permissions. One example would be a user that can't create a new database but has the required connection configs and want to test the connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24185: fix: db validate parameters permission
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24185:
URL: https://github.com/apache/superset/pull/24185#issuecomment-1559827948
@dpgaspar why are we changing these from `can_read` to `can_write` for both these endpoints given (in theory) they're read requests, i.e., the underlying model is not being augmented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org