You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/31 05:00:55 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
BradWalker opened a new pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336
Remove the use of a deprecated API, getURL()..
[repeat] /home/bwalker/src/netbeans/platform/openide.loaders/src/org/openide/loaders/XMLDataObject.java:528: warning: [deprecation] getURL() in FileObject has been deprecated
[repeat] String loc = getPrimaryFile().getURL().toExternalForm();
[repeat] ^
In addition, this deprecated API never throws an exception. So once the change was made, also
had to removed references to the unused exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633083814
##########
File path: java/i18n/src/org/netbeans/modules/i18n/wizard/Util.java
##########
@@ -179,15 +179,9 @@ static boolean wizardEnabled(Node[] activatedNodes) {
FileObject primaryFile = dobj.getPrimaryFile();
boolean isLocal;
- try {
- isLocal = !primaryFile.isVirtual()
+ isLocal = !primaryFile.isVirtual()
Review comment:
Seems to have lost some where (see other comments)
##########
File path: enterprise/web.freeform/src/org/netbeans/modules/web/freeform/WebModules.java
##########
@@ -193,11 +193,7 @@ private FileObject getFile (Element parent, String fileElName) {
Set<FileObject> srcRootSet = new HashSet<FileObject>();
for (int i = 0; i < sg.length; i++) {
URL entry;
- try {
- entry = sg[i].getRootFolder().getURL();
- } catch (FileStateInvalidException x) {
- throw new AssertionError(x);
- }
+ entry = sg[i].getRootFolder().toURL();
Review comment:
Looks still the same
##########
File path: enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDDataNode.java
##########
@@ -73,11 +73,7 @@ public String getShortDescription() {
if (saxError == null) {
if (dataObject instanceof DDFragmentDataObject) {
URL url = null;
- try {
- url = dataObject.getPrimaryFile().getURL();
- } catch (FileStateInvalidException ex) {
- // ignore
- }
+ url = dataObject.getPrimaryFile().toURL();
Review comment:
Looks still the same - could you please check whether the commit really made it? I'm looking at the changes from the github UI and lines 75+76 are still separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#issuecomment-841740228
Hey @matthiasblaesing , I've made all the suggested changes you asked for.. Thanks for the code review..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018753
##########
File path: ide/image/src/org/netbeans/modules/image/ImageDataObject.java
##########
@@ -353,13 +333,8 @@ public ImageHeightProperty() {
/** Gets value of property. Overrides superclass method. */
public Integer getValue() throws InvocationTargetException {
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#issuecomment-841839942
Hey @matthiasblaesing , I fixed those easy issues that you found.. My eyes kept deceiving me because they were so simple.. 8-)
As always, thanks for the feedback/review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#issuecomment-861359798
@BradWalker would you try to merge using your commiter rights? if it's ok with @matthiasblaesing of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#issuecomment-841740228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r485096324
##########
File path: enterprise/web.freeform/src/org/netbeans/modules/web/freeform/WebModules.java
##########
@@ -193,11 +193,7 @@ private FileObject getFile (Element parent, String fileElName) {
Set<FileObject> srcRootSet = new HashSet<FileObject>();
for (int i = 0; i < sg.length; i++) {
URL entry;
- try {
- entry = sg[i].getRootFolder().getURL();
- } catch (FileStateInvalidException x) {
- throw new AssertionError(x);
- }
+ entry = sg[i].getRootFolder().toURL();
Review comment:
Please merge new lines 195+196
##########
File path: enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDDataNode.java
##########
@@ -73,11 +73,7 @@ public String getShortDescription() {
if (saxError == null) {
if (dataObject instanceof DDFragmentDataObject) {
URL url = null;
- try {
- url = dataObject.getPrimaryFile().getURL();
- } catch (FileStateInvalidException ex) {
- // ignore
- }
+ url = dataObject.getPrimaryFile().toURL();
Review comment:
could you please merge the new lines 75 + 76? The null assignement is unecessary.
##########
File path: ide/image/src/org/netbeans/modules/image/ImageDataObject.java
##########
@@ -330,13 +315,8 @@ public ImageWidthProperty() {
/** Gets value of property. Overrides superclass method. */
public Integer getValue() throws InvocationTargetException {
Review comment:
Is it intentional, that the `InvocationTargetException` was not removed? This is in contrast to new line 238.
##########
File path: java/dbschema/src/org/netbeans/modules/dbschema/SchemaElementUtil.java
##########
@@ -59,7 +59,7 @@ public static SchemaElement forName(String name, Object obj) {
String tempURL = ""; //NOI18N
if (schemaFO != null)
try {
- tempURL = schemaFO.getURL().toString();
+ tempURL = schemaFO.toURL().toString();
} catch (Exception exc) {
Review comment:
Is this catch still necessary? At lease I would reduce it to `RuntimeException` or is thee another checked exception that could be thrown?
##########
File path: java/i18n/src/org/netbeans/modules/i18n/wizard/Util.java
##########
@@ -179,15 +179,9 @@ static boolean wizardEnabled(Node[] activatedNodes) {
FileObject primaryFile = dobj.getPrimaryFile();
boolean isLocal;
- try {
- isLocal = !primaryFile.isVirtual()
+ isLocal = !primaryFile.isVirtual()
Review comment:
Please merge new lines 181 + 182
##########
File path: ide/image/src/org/netbeans/modules/image/ImageDataObject.java
##########
@@ -353,13 +333,8 @@ public ImageHeightProperty() {
/** Gets value of property. Overrides superclass method. */
public Integer getValue() throws InvocationTargetException {
Review comment:
Is it intentional, that the `InvocationTargetException` was not removed? This is in contrast to new line 238.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633083814
##########
File path: java/i18n/src/org/netbeans/modules/i18n/wizard/Util.java
##########
@@ -179,15 +179,9 @@ static boolean wizardEnabled(Node[] activatedNodes) {
FileObject primaryFile = dobj.getPrimaryFile();
boolean isLocal;
- try {
- isLocal = !primaryFile.isVirtual()
+ isLocal = !primaryFile.isVirtual()
Review comment:
Seems to have lost some where (see other comments)
##########
File path: enterprise/web.freeform/src/org/netbeans/modules/web/freeform/WebModules.java
##########
@@ -193,11 +193,7 @@ private FileObject getFile (Element parent, String fileElName) {
Set<FileObject> srcRootSet = new HashSet<FileObject>();
for (int i = 0; i < sg.length; i++) {
URL entry;
- try {
- entry = sg[i].getRootFolder().getURL();
- } catch (FileStateInvalidException x) {
- throw new AssertionError(x);
- }
+ entry = sg[i].getRootFolder().toURL();
Review comment:
Looks still the same
##########
File path: enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDDataNode.java
##########
@@ -73,11 +73,7 @@ public String getShortDescription() {
if (saxError == null) {
if (dataObject instanceof DDFragmentDataObject) {
URL url = null;
- try {
- url = dataObject.getPrimaryFile().getURL();
- } catch (FileStateInvalidException ex) {
- // ignore
- }
+ url = dataObject.getPrimaryFile().toURL();
Review comment:
Looks still the same - could you please check whether the commit really made it? I'm looking at the changes from the github UI and lines 75+76 are still separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker merged pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker merged pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018084
##########
File path: enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDDataNode.java
##########
@@ -73,11 +73,7 @@ public String getShortDescription() {
if (saxError == null) {
if (dataObject instanceof DDFragmentDataObject) {
URL url = null;
- try {
- url = dataObject.getPrimaryFile().getURL();
- } catch (FileStateInvalidException ex) {
- // ignore
- }
+ url = dataObject.getPrimaryFile().toURL();
Review comment:
Fixed..
##########
File path: enterprise/web.freeform/src/org/netbeans/modules/web/freeform/WebModules.java
##########
@@ -193,11 +193,7 @@ private FileObject getFile (Element parent, String fileElName) {
Set<FileObject> srcRootSet = new HashSet<FileObject>();
for (int i = 0; i < sg.length; i++) {
URL entry;
- try {
- entry = sg[i].getRootFolder().getURL();
- } catch (FileStateInvalidException x) {
- throw new AssertionError(x);
- }
+ entry = sg[i].getRootFolder().toURL();
Review comment:
fixed..
##########
File path: ide/image/src/org/netbeans/modules/image/ImageDataObject.java
##########
@@ -330,13 +315,8 @@ public ImageWidthProperty() {
/** Gets value of property. Overrides superclass method. */
public Integer getValue() throws InvocationTargetException {
Review comment:
Yes, it was intentional.. This would involve a public method change. And while I would like to do it, I didn't think it would get approved with that change.
I'm happy to do it and learn how to make changes like this, but I need a little bit of guidance how to do this.
##########
File path: java/dbschema/src/org/netbeans/modules/dbschema/SchemaElementUtil.java
##########
@@ -59,7 +59,7 @@ public static SchemaElement forName(String name, Object obj) {
String tempURL = ""; //NOI18N
if (schemaFO != null)
try {
- tempURL = schemaFO.getURL().toString();
+ tempURL = schemaFO.toURL().toString();
} catch (Exception exc) {
Review comment:
Fixed..
##########
File path: java/i18n/src/org/netbeans/modules/i18n/wizard/Util.java
##########
@@ -179,15 +179,9 @@ static boolean wizardEnabled(Node[] activatedNodes) {
FileObject primaryFile = dobj.getPrimaryFile();
boolean isLocal;
- try {
- isLocal = !primaryFile.isVirtual()
+ isLocal = !primaryFile.isVirtual()
Review comment:
fixed..
##########
File path: ide/image/src/org/netbeans/modules/image/ImageDataObject.java
##########
@@ -353,13 +333,8 @@ public ImageHeightProperty() {
/** Gets value of property. Overrides superclass method. */
public Integer getValue() throws InvocationTargetException {
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018542
##########
File path: java/i18n/src/org/netbeans/modules/i18n/wizard/Util.java
##########
@@ -179,15 +179,9 @@ static boolean wizardEnabled(Node[] activatedNodes) {
FileObject primaryFile = dobj.getPrimaryFile();
boolean isLocal;
- try {
- isLocal = !primaryFile.isVirtual()
+ isLocal = !primaryFile.isVirtual()
Review comment:
fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018283
##########
File path: ide/image/src/org/netbeans/modules/image/ImageDataObject.java
##########
@@ -330,13 +315,8 @@ public ImageWidthProperty() {
/** Gets value of property. Overrides superclass method. */
public Integer getValue() throws InvocationTargetException {
Review comment:
Yes, it was intentional.. This would involve a public method change. And while I would like to do it, I didn't think it would get approved with that change.
I'm happy to do it and learn how to make changes like this, but I need a little bit of guidance how to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018084
##########
File path: enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDDataNode.java
##########
@@ -73,11 +73,7 @@ public String getShortDescription() {
if (saxError == null) {
if (dataObject instanceof DDFragmentDataObject) {
URL url = null;
- try {
- url = dataObject.getPrimaryFile().getURL();
- } catch (FileStateInvalidException ex) {
- // ignore
- }
+ url = dataObject.getPrimaryFile().toURL();
Review comment:
Fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018167
##########
File path: enterprise/web.freeform/src/org/netbeans/modules/web/freeform/WebModules.java
##########
@@ -193,11 +193,7 @@ private FileObject getFile (Element parent, String fileElName) {
Set<FileObject> srcRootSet = new HashSet<FileObject>();
for (int i = 0; i < sg.length; i++) {
URL entry;
- try {
- entry = sg[i].getRootFolder().getURL();
- } catch (FileStateInvalidException x) {
- throw new AssertionError(x);
- }
+ entry = sg[i].getRootFolder().toURL();
Review comment:
fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2336: [NETBEANS-4755] - remove use of deprecated API - getURL()
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2336:
URL: https://github.com/apache/netbeans/pull/2336#discussion_r633018480
##########
File path: java/dbschema/src/org/netbeans/modules/dbschema/SchemaElementUtil.java
##########
@@ -59,7 +59,7 @@ public static SchemaElement forName(String name, Object obj) {
String tempURL = ""; //NOI18N
if (schemaFO != null)
try {
- tempURL = schemaFO.getURL().toString();
+ tempURL = schemaFO.toURL().toString();
} catch (Exception exc) {
Review comment:
Fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists