You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by rm...@apache.org on 2014/11/28 12:36:43 UTC
[2/2] tomee git commit: missing test to get something useful
missing test to get something useful
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/b72144c0
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/b72144c0
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/b72144c0
Branch: refs/heads/tomee-1.7.x
Commit: b72144c035b3c00cbcd1b835b7d7afa51a61b984
Parents: 92e2c56
Author: Romain Manni-Bucau <rm...@apache.org>
Authored: Fri Nov 28 12:31:00 2014 +0100
Committer: Romain Manni-Bucau <rm...@apache.org>
Committed: Fri Nov 28 12:31:00 2014 +0100
----------------------------------------------------------------------
.../main/java/org/apache/openejb/assembler/classic/Assembler.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/b72144c0/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
index 6b77b86..a0ebd92 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
@@ -956,7 +956,7 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
if (si.factoryMethod != null) {
query.put("factory-name", si.factoryMethod);
}
- if (si.constructorArgs != null) {
+ if (si.constructorArgs != null && !si.constructorArgs.isEmpty()) {
query.put("constructor", Join.join(",", si.constructorArgs));
}
appInfo.properties.put(si.id, "new://Service?" + URISupport.createQueryString(query));