You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/09 01:07:41 UTC

[GitHub] [tvm] mehrdadh opened a new pull request #9688: [TVMC][microTVM] Fix TVMC Error When USE_MICRO is OFF

mehrdadh opened a new pull request #9688:
URL: https://github.com/apache/tvm/pull/9688


   This PR fixes issue https://github.com/apache/tvm/issues/9679
   
   cc @gromero @leandron 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] gromero commented on pull request #9688: [TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF

Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9688:
URL: https://github.com/apache/tvm/pull/9688#issuecomment-989868119


   @mehrdadh btw, the PR title is cool, but the commit title is not as good as the PR title and when there is only one commit in the PR the title that will be used for the commit that gets merged is the one from the commit (if the PR has multiple commits the PR title is used instead). Hence  it would be cool if next time (since we want  to avoid another CI retrigger) we try to be consistent for the sake of merging better commit messages in general :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mehrdadh commented on pull request #9688: [TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #9688:
URL: https://github.com/apache/tvm/pull/9688#issuecomment-989962196


   @gromero this was on ubuntu 18.08 and I was using python3.6
   ```
   No LSB modules are available.
   Distributor ID: Ubuntu
   Description:    Ubuntu 18.04.5 LTS
   Release:        18.04
   Codename:       bionic
   ```
   Thanks for checking it. I think this clearly shows that we need nightly test of tlcpack on different OSs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] leandron merged pull request #9688: [TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF

Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9688:
URL: https://github.com/apache/tvm/pull/9688


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] gromero edited a comment on pull request #9688: [TVMC][microTVM] Fix TVMC AttributeError When USE_MICRO is OFF

Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #9688:
URL: https://github.com/apache/tvm/pull/9688#issuecomment-989868119


   @mehrdadh btw, the PR title is cool, but the commit title is not as good as the PR title and when there is only one commit in the PR the title that will be used for the commit that gets merged is the one from the commit (if the PR has multiple commits the PR title is used instead). Hence  it would be cool if next time (since we want  to avoid a CI retrigger) we try to be consistent for the sake of merging better commit messages in general :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org