[GitHub] [skywalking-kubernetes] innerpeacez commented on a diff in pull request #111: default rbac for oap

["innerpeacez (via GitHub)" <gi...@apache.org>]

innerpeacez commented on code in PR #111:
URL: https://github.com/apache/skywalking-kubernetes/pull/111#discussion_r1130757731


##########
chart/skywalking/values.yaml:
##########
@@ -19,6 +19,9 @@
 
 serviceAccounts:
   oap:
+    # By default, create SkyWalking's ServiceAccount. If set to false, you also need to change `serviceAccounts.oap.name` value to a custom ServiceAccount name.
+    create: true
+    name: ""

Review Comment:
   ```
   serviceAccounts:
     oap:
       # By default, create SkyWalking's ServiceAccount. If set to false, you also need to change `serviceAccounts.oap.name` value to a custom ServiceAccount name.
       create: true
       name: ""
   ```
   I think this is more convenient. When we deploy multiple skywalking clusters in one k8s at the same time, multiple clusterRole may be created. At this time, we can use the name field to distinguish different SW clusterRole, so as not to cause clusterRole conflicts.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org