You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/21 18:34:22 UTC

[GitHub] [trafficcontrol] dsouza93 opened a new issue #4982: Support Queuing by Server Type

dsouza93 opened a new issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the
   [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   -  new feature / enhancement request
   -  improvement request (usability, performance, tech debt, etc.)
   -  other <!--(Please do not submit support requests here - see above)-->
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Documentation
   -  Traffic Ops
   -  Traffic Ops ORT
   -  Traffic Portal
   
   ## Current behavior:
   <!-- Describe how the bug manifests / how the current features are insufficient. -->
   There has been the need to queue only the edge caches or only the mid caches. Currently, this has to either be done by writing a script to hit the API, or hacky ways like admin_downing mid caches in each cache group to queue updates on edges.
   
   ## Expected / new behavior:
   <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
   I'd like the ability to only queue updates on a specific tier. To expand on this it might be nice to be able to queue based on a profile regex as well.
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug or you can illustrate your feature request better with an example,
   please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
   -->
   N/A
   ## Anything else:
   <!-- e.g. stacktraces, related issues, suggestions how to fix -->
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-678438629


   currently you can queue updates on servers at 3 levels:
   1. all servers in a cdn
   2. all servers in a cache group
   3. an individual server
   
   I know that #3 will also queue updates on any "child" servers of that server automatically. I'm not sure if #2 does the same thing. I.e. if you queue updates on a cache group's servers, does it also queue updates on any servers in child cache group(s). I'd need to look into that.
   
   my point being, when you say "queue updates by server type", you really only want updates queued for servers of that type and NOT "children" servers as it does now, correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-678438629


   currently you can queue updates on servers at 3 levels:
   1. all servers in a cdn
   2. all servers in a cache group
   3. an individual server
   
   I know that #3 will also queue updates on any "child" servers of that server automatically. I'm not sure if #2 does the same thing. I.e. if you queue updates on a cache group's servers, does it also queue updates on any servers in a child cache groups. I'd need to look into that.
   
   my point being, when you say "queue updates by server type", you really only want updates queued for servers of that type and not "children" servers as it does now, correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-879255776


   > Rather than adding a new endpoint, would it make sense to just add `type` and `profile` query parameters to the existing `/cdns/{id}/queue_update` endpoint? I think most of the time you're queuing within a single CDN, so it might make sense to keep it CDN-specific, but within that CDN you can narrow down by server type and profile.
   
   this makes sense to me. i think most (all?) of the time, you are concerned with a specific cdn anyhow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rawlinp closed issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-678438629


   currently you can queue updates on servers at 3 levels:
   1. all servers in a cdn
   2. all servers in a cache group
   3. an individual server
   
   I know that #3 will also queue updates on any "child" servers of that server automatically. I'm not sure if #2 does the same thing. I.e. if you queue updates on a cache group's servers, does it also queue updates on any servers in a child cache groups.
   
   my point being, when you say "queue updates by server type", you really only want updates queued for servers of that type and not "children" servers as it does now, correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-879255776


   > Rather than adding a new endpoint, would it make sense to just add `type` and `profile` query parameters to the existing `/cdns/{id}/queue_update` endpoint? I think most of the time you're queuing within a single CDN, so it might make sense to keep it CDN-specific, but within that CDN you can narrow down by server type and profile.
   
   this makes sense to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] srijeet0406 commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-810373975


   @mitchell852 I can take this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] dsouza93 commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
dsouza93 commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-871600226


   Queueing updates by type and profile only seems acceptable and more user friendly! Sounds good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] srijeet0406 commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-871593928


   Talked to @mitchell852 about this, and for this issue, I'll be adding queueing updates by Type only. We can keep adding to that endpoint later as we'd like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rawlinp closed issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-747841556


   Maybe we need to consider a new endpoint like:
   
   POST (or PUT) /api/queue_updates with a bunch of supported query params such as:
   
   /api/queue_updates?cdn=
   /api/queue_updates?cacheGroup=
   /api/queue_updates?server=(hostname? id? both?)
   /api/queue_updates?type=
   /api/queue_updates?profile=
   /api/queue_updates?topology=
   /api/queue_updates?deliveryService=(xmlId? id? both?)
   /api/queue_updates?physLocation=
   /api/queue_updates?serverCapability=
   /api/queue_updates?status=
   
   that would give the user lots of options on how they wan to queue updates :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-678438629


   currently you can queue updates on servers at 3 levels:
   1. all servers in a cdn
   2. all servers in a cache group
   3. an individual server
   
   I know that #3 will also queue updates on any "child" servers of that server automatically. I'm not sure if #2 does the same thing. I.e. if you queue updates on a cache group's servers, does it also queue updates on any servers in child cache group(s). I'd need to look into that.
   
   my point being, when you say "queue updates by server type", you really only want updates queued for servers of that type and NOT "children" servers as it does now, correct? Example, if you want to queue updates on all MID servers, you only want those MID servers queued, right? nothing else....


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-678438629


   currently you can queue updates on servers at 3 levels:
   1. all servers in a cdn
   2. all servers in a cache group
   3. an individual server
   
   I know that #3 will also queue updates on any "child" servers of that server automatically. I'm not sure if #2 does the same thing. I.e. if you queue updates on a cache group's servers, does it also queue updates on any servers in a child cache groups. I'd need to look into that.
   
   my point being, when you say "queue updates by server type", you really only want updates queued for servers of that type and NOT "children" servers as it does now, correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rawlinp commented on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-878583835


   Rather than adding a new endpoint, would it make sense to just add `type` and `profile` query parameters to the existing `/cdns/{id}/queue_update` endpoint? I think most of the time you're queuing within a single CDN, so it might make sense to keep it CDN-specific, but within that CDN you can narrow down by server type and profile.
   
   I would prefer us to move away from having to do targeted queues in the first place -- in general if you queue updates on a server that doesn't actually have updates, it should be a no-op. The problem is that it adds load on Traffic Ops to serve requests from `t3c` when they're not actually needed. However, we are trying to get to a point where Traffic Ops can easily handle the load from thousands of `t3c` instances at a time, so eventually we should be able to just queue entire CDNs at a time and have the change fully propagated in a few minutes rather than an hour.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rawlinp closed issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] srijeet0406 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
srijeet0406 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-871593928


   Talked to @mitchell852 about this, and for this issue, I'll be adding queueing updates by Type and profile regex only. We can keep adding to that endpoint later as we'd like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] srijeet0406 edited a comment on issue #4982: Support Queuing Updates by Server Type

Posted by GitBox <gi...@apache.org>.
srijeet0406 edited a comment on issue #4982:
URL: https://github.com/apache/trafficcontrol/issues/4982#issuecomment-871593928


   Talked to @mitchell852 about this, and for this issue, I'll be adding queueing updates by Type and profile only. We can keep adding to that endpoint later as we'd like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org