You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/08/01 19:21:42 UTC
[jclouds] JCLOUDS-646: Refactor openstack-common (#461)
This PR provides the necessary changes for [JCLOUDS-646](https://issues.apache.org/jira/browse/JCLOUDS-646). This is essentially is a copy/paste/rename of the misnamed keystone packages in `openstack-common` to the `rackspace-cloudidentity` project.
A follow-up PR is required to change the `cloudservers` auth dependencies from `openstack-common` to `rackspace-cloudidentity`.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds fix/cloudidentity
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/461
-- Commit Summary --
* JCLOUDS-646: Copied Cloud Identity v1.1 classes from openstack-common and fixed incorrect Keystone package names
-- File Changes --
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/AuthenticationApi.java (48)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/binders/BindCredentialsToJsonPayload.java (48)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/config/Authentication.java (31)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/config/AuthenticationServiceModule.java (117)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/domain/Auth.java (123)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/domain/Endpoint.java (198)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/domain/Token.java (137)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/functions/EndpointToRegion.java (27)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/functions/EndpointToSupplierURI.java (29)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/functions/PublicURLOrInternalIfNull.java (39)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/functions/RegionFirstPartOfDNSNameOrProvider.java (47)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/handlers/RetryOnRenew.java (133)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/suppliers/RegionIdToURIFromAuthForServiceSupplier.java (67)
A apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/suppliers/V1DefaultRegionIdSupplier.java (85)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/functions/PublicURLOrInternalIfNullTest.java (44)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/functions/RegionFirstPartOfDNSNameOrProviderTest.java (48)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/handlers/RetryOnRenewTest.java (166)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/internal/BaseKeystoneRestClientExpectTest.java (62)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/parse/ParseAuthTest.java (77)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/suppliers/RegionIdToURIFromAuthForServiceSupplierTest.java (70)
A apis/rackspace-cloudidentity/src/test/java/org/jclouds/rackspace/cloudidentity/v1_1/suppliers/V1DefaultRegionIdSupplierTest.java (62)
A apis/rackspace-cloudidentity/src/test/resources/auth1_1.json (25)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/461.patch
https://github.com/jclouds/jclouds/pull/461.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Everett Toews <no...@github.com>.
+1
rackspace-cloudidentity is definitely the proper home for this (legacy) code.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-51119001
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1048](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1048/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50918713
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Andrew Phillips <no...@github.com>.
> Does that clarify?
Yes, thanks.
> It will eventually be deprecated/removed once there are no longer any dependencies on it.
Out of curiosity...any reason not to deprecate now (e.g. immediately after 1.8.0)? Then we will at least see where those dependencies are? Or do we see this code staying around long past 2.0 (or whatever the next release will be)..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50948658
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Andrew Phillips <no...@github.com>.
> Sound good?
Works for me! I'm hardly the expert as far as these providers are concerned ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50949781
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Andrew Phillips <no...@github.com>.
I see only new classes...is the intention to leave the ones in openstack-common in place, or can they be deprecated/removed?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50941530
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Jeremy Daggett <no...@github.com>.
Pushed to master `95a3c7e`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-51219609
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Jeremy Daggett <no...@github.com>.
@demobox `openstack-common` needs to stay in place for the time being. It will eventually be deprecated/removed once there are no longer any dependencies on it. This is a step in that direction and decouples what is necessary to continue supporting the Rackspace First-Gen Server API in `cloudservers` moving forward. Does that clarify?
These Checkstyle warnings are a real nuisance. :-1: I would rather enforce checkstyle to fail the build on warnings/errors than deal with all the back and forth in PR reviews. We would *never* miss them and the problem takes care of itself. ;)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50946518
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Andrew Phillips <no...@github.com>.
> We would never miss them and the problem takes care of itself. ;)
Can do! @andrewgaul has suggested something similar. I've enable this for the Java 7 PR builder...let's see if it helps.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50948494
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1520](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1520/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50968978
Re: [jclouds] JCLOUDS-646: Refactor openstack-common (#461)
Posted by Jeremy Daggett <no...@github.com>.
In my analysis, the only deps on `openstack-common` are the cloudfiles/cloudservers APIs. The cloudservers API will live on post-2.0, and I still need to unasync the API and update the deps to point to `rackspace-cloudidentity`. Once that happens, I plan to deprecate cloudfiles/swift/openstack-common. Sound good?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/461#issuecomment-50949618