Re: [PR] [Gluten-229] Support Spark SortShuffleManager for ClickHouse Backend [incubator-gluten]

["zml1206 (via GitHub)" <gi...@apache.org>]

zml1206 commented on code in PR #230:
URL: https://github.com/apache/incubator-gluten/pull/230#discussion_r1627944846


##########
jvm/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala:
##########
@@ -76,8 +69,26 @@ object JoinSelectionOverrides extends Strategy with JoinSelectionHelper with SQL
       if (GlutenConfig.getSessionConf.forceShuffledHashJoin) {
         // Force use of ShuffledHashJoin in preference to SortMergeJoin. With no respect to
         // conf setting "spark.sql.join.preferSortMergeJoin".
-        val leftBuildable = canBuildShuffledHashJoinLeft(joinType)
-        val rightBuildable = canBuildShuffledHashJoinRight(joinType)
+        val (leftBuildable, rightBuildable) = if (GlutenConfig.getConf.isClickHouseBackend) {
+          // Currently, ClickHouse backend can not support AQE, so it needs to use join hint
+          // to decide the build side, after supporting AQE, will remove this.

Review Comment:
   What is the relationship between do not support AQE and needs to use join hint? I'm preparing to move JoinSelectionOverrides to ColumnarOverrides. Can you help explain why? @zzcclp 
   Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org