You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by "John Jensen (JIRA)" <ji...@apache.org> on 2012/11/27 04:49:58 UTC
[jira] [Created] (CRUNCH-121) Bug in Left Outer Join and Full outer
join
John Jensen created CRUNCH-121:
----------------------------------
Summary: Bug in Left Outer Join and Full outer join
Key: CRUNCH-121
URL: https://issues.apache.org/jira/browse/CRUNCH-121
Project: Crunch
Issue Type: Bug
Components: Core
Affects Versions: 0.4.0
Reporter: John Jensen
Assignee: Josh Wills
Attachments: BrokenJoinTest.java
Both left outer join and full outer join appear to have problems with patterns like:
k1, 0, left, null
k2, 1, null, right
I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-121) Bug in Left Outer Join and Full outer
join
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Wills updated CRUNCH-121:
------------------------------
Assignee: Kiyan Ahmadizadeh (was: Josh Wills)
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Kiyan Ahmadizadeh
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch, CRUNCH-121.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CRUNCH-121) Bug in Left Outer Join and Full
outer join
Posted by "Kiyan Ahmadizadeh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kiyan Ahmadizadeh resolved CRUNCH-121.
--------------------------------------
Resolution: Fixed
John's patch looks good and builds correctly on my machine with mvn install.
Change pushed to master.
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Kiyan Ahmadizadeh
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch, CRUNCH-121.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-121) Bug in Left Outer Join and Full
outer join
Posted by "John Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504348#comment-13504348 ]
John Jensen commented on CRUNCH-121:
------------------------------------
The fix is simple, I'll attach a fix shortly
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Josh Wills
> Attachments: BrokenJoinTest.java
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-121) Bug in Left Outer Join and Full
outer join
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504364#comment-13504364 ]
Josh Wills commented on CRUNCH-121:
-----------------------------------
John, thanks for this, it looks right to me. I'm going to integrate your patch w/an adaptation of the unit test you provided to text the fix and post it here so [~kiyan] can take a look at it tomorrow morning and check that there isn't an edge case here I don't see.
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Josh Wills
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-121) Bug in Left Outer Join and Full outer
join
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Wills updated CRUNCH-121:
------------------------------
Attachment: CRUNCH-121.patch
Fix + test in this patch.
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Josh Wills
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch, CRUNCH-121.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-121) Bug in Left Outer Join and Full outer
join
Posted by "John Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Jensen updated CRUNCH-121:
-------------------------------
Attachment: CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Josh Wills
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-121) Bug in Left Outer Join and Full outer
join
Posted by "John Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Jensen updated CRUNCH-121:
-------------------------------
Attachment: BrokenJoinTest.java
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Josh Wills
> Attachments: BrokenJoinTest.java
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-121) Bug in Left Outer Join and Full
outer join
Posted by "Kiyan Ahmadizadeh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505071#comment-13505071 ]
Kiyan Ahmadizadeh commented on CRUNCH-121:
------------------------------------------
Refreshing myself on the join framework and taking a look now. Will commit if all looks well.
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Kiyan Ahmadizadeh
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch, CRUNCH-121.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-121) Bug in Left Outer Join and Full
outer join
Posted by "John Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504366#comment-13504366 ]
John Jensen commented on CRUNCH-121:
------------------------------------
Thanks
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Josh Wills
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-121) Bug in Left Outer Join and Full outer
join
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Wills updated CRUNCH-121:
------------------------------
Fix Version/s: 0.5.0
Thanks guys.
> Bug in Left Outer Join and Full outer join
> ------------------------------------------
>
> Key: CRUNCH-121
> URL: https://issues.apache.org/jira/browse/CRUNCH-121
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4.0
> Reporter: John Jensen
> Assignee: Kiyan Ahmadizadeh
> Fix For: 0.5.0
>
> Attachments: BrokenJoinTest.java, CRUNCH-121-fix-bug-in-full-outer-and-left-outer-join.patch, CRUNCH-121.patch
>
>
> Both left outer join and full outer join appear to have problems with patterns like:
> k1, 0, left, null
> k2, 1, null, right
> I'll attach a simple test that reproduces the problem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira