[GitHub] [pulsar] yuruguo commented on a diff in pull request #15657: [improve][admin] Enable users to specify TTL options in units other than seconds

[GitBox <gi...@apache.org>]

yuruguo commented on code in PR #15657:
URL: https://github.com/apache/pulsar/pull/15657#discussion_r879474339


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java:
##########
@@ -277,22 +277,31 @@ private class SetMessageTTL extends CliCommand {
         @Parameter(description = "persistent://tenant/namespace/topic", required = true)
         private java.util.List<String> params;
 
-        @Parameter(names = { "-t", "--ttl" }, description = "Message TTL for topic in second, "
-                + "allowed range from 1 to Integer.MAX_VALUE", required = true)
-        private int messageTTLInSecond;
+        @Parameter(names = { "-t", "--ttl" },
+                description = "Message TTL for topic in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), "

Review Comment:
   `second` -> `seconds`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org