You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/12 16:04:22 UTC
[GitHub] [incubator-doris] xiepengcheng01 opened a new pull request, #10081: support backup/restore connect to HDFS
xiepengcheng01 opened a new pull request, #10081:
URL: https://github.com/apache/incubator-doris/pull/10081
# Proposed changes
Support backup and restore directly connect to HDFS.
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #10081: [Feature] support backup/restore connect to HDFS
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #10081:
URL: https://github.com/apache/incubator-doris/pull/10081#discussion_r898654147
##########
fe/fe-core/src/main/java/org/apache/doris/backup/HdfsStorage.java:
##########
@@ -17,17 +17,484 @@
package org.apache.doris.backup;
+import org.apache.commons.collections.map.CaseInsensitiveMap;
+import org.apache.doris.analysis.StorageBackend;
+import org.apache.doris.catalog.AuthType;
import org.apache.doris.common.UserException;
+import org.apache.doris.common.util.BrokerUtil;
+import org.apache.doris.common.util.URI;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataInputStream;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import java.io.BufferedInputStream;
+import java.io.BufferedOutputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.file.FileVisitOption;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Comparator;
+import java.util.List;
import java.util.Map;
Review Comment:
import order should be
···
org.apache.doris
<blank line>
third party package
<blank line>
standard java package
<blank line>
···
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10081: [Feature] support backup/restore connect to HDFS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10081:
URL: https://github.com/apache/incubator-doris/pull/10081#issuecomment-1158481799
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #10081: [Feature] support backup/restore connect to HDFS
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #10081:
URL: https://github.com/apache/incubator-doris/pull/10081#discussion_r898656086
##########
be/test/util/hdfs_storage_backend_test.cpp:
##########
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "util/hdfs_storage_backend.h"
+
+#include <gtest/gtest.h>
+
+#include <boost/lexical_cast.hpp>
+#include <boost/uuid/uuid.hpp>
+#include <boost/uuid/uuid_generators.hpp>
+#include <boost/uuid/uuid_io.hpp>
+#include <fstream>
+#include <map>
+#include <string>
+
+#include "util/file_utils.h"
+#include "util/storage_backend.h"
+
+namespace doris {
+static const std::string fs_name = "hdfs://127.0.0.1:9000"; // An invalid address
+static const std::string user = "test";
+static const std::string base_path = "/user/test";
+
+#define HDFSStorageBackendTest DISABLED_S3StorageBackendTest
Review Comment:
```suggestion
#define HDFSStorageBackendTest DISABLED_HDFSStorageBackendTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10081: [Feature] support backup/restore connect to HDFS
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10081:
URL: https://github.com/apache/doris/pull/10081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #10081: support backup/restore connect to HDFS
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #10081:
URL: https://github.com/apache/incubator-doris/pull/10081#discussion_r895279349
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -150,7 +136,7 @@ struct TBrokerRangeDesc {
// it's usefull when format_type == FORMAT_JSON
14: optional bool num_as_string;
15: optional bool fuzzy_parse;
- 16: optional THdfsParams hdfs_params
+ 16: optional map<string, string> hdfs_params;
Review Comment:
In this way, when there are new and old versions mixed, there will be compatibility problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10081: [Feature] support backup/restore connect to HDFS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10081:
URL: https://github.com/apache/incubator-doris/pull/10081#issuecomment-1158481778
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org