You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ca...@apache.org on 2005/06/22 21:34:28 UTC
svn commit: r192977 - in /maven/maven-1/plugins/trunk/checkstyle:
plugin.jelly plugin.properties xdocs/changes.xml xdocs/properties.xml
Author: carlos
Date: Wed Jun 22 12:34:27 2005
New Revision: 192977
URL: http://svn.apache.org/viewcvs?rev=192977&view=rev
Log:
Ability to check test sources using property maven.checkstyle.check.tests
Modified:
maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
maven/maven-1/plugins/trunk/checkstyle/plugin.properties
maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
maven/maven-1/plugins/trunk/checkstyle/xdocs/properties.xml
Modified: maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/plugin.jelly?rev=192977&r1=192976&r2=192977&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/plugin.jelly (original)
+++ maven/maven-1/plugins/trunk/checkstyle/plugin.jelly Wed Jun 22 12:34:27 2005
@@ -168,6 +168,20 @@
</ant:fileset>
+ <!-- run checkstyle on tests -->
+ <j:if test="${(unitTestSourcesPresent == 'true') and (context.getVariable('maven.checkstyle.check.tests'))}">
+ <ant:pathconvert property="testSrcSetString" pathSep="||||"
+ refid="maven.test.compile.src.set"/>
+ <u:tokenize var="testDirs" delim="||||">${testSrcSetString}</u:tokenize>
+
+ <j:forEach var="testDir" items="${testDirs}">
+ <ant:fileset dir="${testDir}"
+ includes="${maven.checkstyle.includes}"
+ excludes="${maven.checkstyle.excludes}"/>
+ </j:forEach>
+ </j:if>
+
+
<ant:classpath>
<ant:path refid="maven.dependency.classpath"/>
<ant:pathelement path="${maven.build.dest}"/>
Modified: maven/maven-1/plugins/trunk/checkstyle/plugin.properties
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/plugin.properties?rev=192977&r1=192976&r2=192977&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/plugin.properties (original)
+++ maven/maven-1/plugins/trunk/checkstyle/plugin.properties Wed Jun 22 12:34:27 2005
@@ -26,7 +26,8 @@
maven.checkstyle.cache.file = ${maven.build.dir}/checkstyle-cachefile
maven.checkstyle.format = sun
maven.checkstyle.header.file = ${basedir}/LICENSE.txt
+maven.checkstyle.check.tests=true
# If useFile is false then the checkstyle task will display violations
# on stdout.
-maven.checkstyle.usefile = true
\ No newline at end of file
+maven.checkstyle.usefile = true
Modified: maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml?rev=192977&r1=192976&r2=192977&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml Wed Jun 22 12:34:27 2005
@@ -26,6 +26,7 @@
</properties>
<body>
<release version="3.0-SNAPSHOT" date="in SVN">
+ <action dev="carlos" type="add" issue="MPCHECKSTYLE-30">Ability to check test sources using property maven.checkstyle.check.tests</action>
<action dev="carlos" type="add">Generate reports filtered by severity</action>
<action dev="carlos" type="update">Support for Java5</action>
<action dev="carlos" type="update">Upgraded to checkstyle 4.0</action>
Modified: maven/maven-1/plugins/trunk/checkstyle/xdocs/properties.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/xdocs/properties.xml?rev=192977&r1=192976&r2=192977&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/xdocs/properties.xml (original)
+++ maven/maven-1/plugins/trunk/checkstyle/xdocs/properties.xml Wed Jun 22 12:34:27 2005
@@ -52,6 +52,14 @@
</td>
</tr>
<tr>
+ <td>maven.checkstyle.check.tests</td>
+ <td>Yes</td>
+ <td>
+ Whether to check test sources or not.
+ The default value is <code>true</code>.
+ </td>
+ </tr>
+ <tr>
<td>maven.checkstyle.format</td>
<td>Yes</td>
<td>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org