You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/11/18 14:46:45 UTC
[GitHub] [zeppelin] milooy opened a new pull request #3975: [ZEPPELIN-5136] Fix bug - 'Clear output' doesn't clears output
milooy opened a new pull request #3975:
URL: https://github.com/apache/zeppelin/pull/3975
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3975: [ZEPPELIN-5136] Fix bug - 'Clear output' doesn't clears output
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3975:
URL: https://github.com/apache/zeppelin/pull/3975#issuecomment-765867377
ping @milooy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3975: [ZEPPELIN-5136] Fix bug - 'Clear output' doesn't clears output
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3975:
URL: https://github.com/apache/zeppelin/pull/3975#discussion_r526155614
##########
File path: zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/control/control.component.ts
##########
@@ -246,12 +247,15 @@ export class NotebookParagraphControlComponent implements OnInit, OnChanges {
}
clearParagraphOutput() {
+ console.log('힝', this.isEntireNoteRunning);
Review comment:
Use english
##########
File path: zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/control/control.component.ts
##########
@@ -246,12 +247,15 @@ export class NotebookParagraphControlComponent implements OnInit, OnChanges {
}
clearParagraphOutput() {
+ console.log('힝', this.isEntireNoteRunning);
if (!this.isEntireNoteRunning) {
this.messageService.paragraphClearOutput(this.pid);
+ this.clearParagraph.emit();
}
}
onRemoveParagraph() {
+ console.log('얘는 아주 잘 됨');
Review comment:
Use english
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3975: [ZEPPELIN-5136] Fix bug - 'Clear output' doesn't clears output
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3975:
URL: https://github.com/apache/zeppelin/pull/3975#issuecomment-774433808
ping @milooy Will you continue work on this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org