[jira] [Commented] (OFBIZ-11014) StringUtil cleanup

["Mathieu Lirzin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859323#comment-16859323 ] 

Mathieu Lirzin commented on OFBIZ-11014:
----------------------------------------

‘StringUtil#toMap’ is only used in the ‘CollectionConverters.StringToMap’ converter so in order to clean ‘StringUtil’ it seems better to inline it. I will commit  [^OFBIZ-11014_0015-Inline-StringUtil-toMap.patch] which is doing that in a couple of days if nobody disagrees.

> StringUtil cleanup
> ------------------
>
>                 Key: OFBIZ-11014
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11014
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch, OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch, OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch, OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch, OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch, OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch, OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch, OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch, OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch, OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch, OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch, OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch, OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch, OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch, OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java. For example the {{StringUtil#split}} method could be replaced by the {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)