[GitHub] [airflow] dstandish commented on a diff in pull request #26052: Run datasets through dataset manager before creation

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #26052:
URL: https://github.com/apache/airflow/pull/26052#discussion_r957872755


##########
airflow/datasets/manager.py:
##########
@@ -68,6 +68,9 @@ def _queue_dagruns(self, dataset: DatasetModel, session: Session) -> None:
         for dag_id in consuming_dag_ids:
             session.merge(DatasetDagRunQueue(dataset_id=dataset.id, target_dag_id=dag_id))
 
+    def resolve_dataset_model(self, dataset: Dataset) -> DatasetModel:

Review Comment:
   i'm not sure resolve is  the right word here.
   
   it's like a mutation hook here.... 
   
   resolve suggests  you are applying some logic to determine which way to go.... but e.g. here you already know it's always gonna be  DatasetModel....  so  what's being  resolved?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org