You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/26 20:25:13 UTC
[GitHub] [druid] vogievetsky opened a new pull request #11308: Web console: Fix maxRowsPerSegment validation in hashed compaction spec
vogievetsky opened a new pull request #11308:
URL: https://github.com/apache/druid/pull/11308
Fixes an issue where a compaction spec, reflected back from Druid, with hashed partitioning will not validate in the compaction dialog. This is due to the fact that `maxRowsPerSegment` was renamed to `targetRowsPerSegment` but when Druid sends back the compaction config with `targetRowsPerSegment` becomes `maxRowsPerSegment`. As a result `maxRowsPerSegment` is not fully deprecated and must still be surfaced in the form for correct validation.
In addition to the above this PR also makes the following fixes:
- It is now possible to add a hidden field to the AutoForm. This means it can be validated correctly but will not surface in the form. This is needed for when `targetRowsPerSegment` will fully replace `maxRowsPerSegment` as we will still need to declare `maxRowsPerSegment` (as hidden) for the validation to work well with old configs that still use `maxRowsPerSegment`.
- The `Submit` button will now be disabled if there is an erroneous JSON state in JSON inputs. Preventing the user from being able to paste an invalid JSON and hit submit (submitting the default config).
- `Date` serialization was fixed in CSV/TSV download
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11308: Web console: Fix maxRowsPerSegment validation in hashed compaction spec
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11308:
URL: https://github.com/apache/druid/pull/11308#issuecomment-849659496
@vogievetsky it looks like the web-console-e2e-tests are failing. If you need to push another patch to fix this PR, can you merge master into your branch. #11283 was merged earlier today, so it should make travis run a lot faster for these web-console only changes 😄 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11308: Web console: Fix maxRowsPerSegment validation in hashed compaction spec
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11308:
URL: https://github.com/apache/druid/pull/11308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #11308: Web console: Fix maxRowsPerSegment validation in hashed compaction spec
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11308:
URL: https://github.com/apache/druid/pull/11308#issuecomment-849773389
Happy days! Thank you for the tip @suneet-s and thank you for the work @clintropolis 🔥
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org