You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/10/12 04:04:28 UTC

[I] Refactor PG/OG statement inheritance relationship [shardingsphere]

RaigorJiang opened a new issue, #28728:
URL: https://github.com/apache/shardingsphere/issues/28728

   `Alter rule` is not a standard SQL, it belongs to the PG dialect.
   Therefore `AlterRuleStatement` should not exist under the `common` package.
   
   <img width="784" alt="image" src="https://github.com/apache/shardingsphere/assets/5668787/3fa7b0ce-f049-4045-822e-a5ba952ecf62">
   
   Expect the abstract statement to be named PostgreSQLXXXStatement and then OpenGaussXXXStatement to inherit from it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor PG/OG statement inheritance relationship [shardingsphere]

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #28728:
URL: https://github.com/apache/shardingsphere/issues/28728#issuecomment-1782446522

   However, letting openGauss inherit the PostgreSQL class will also lead to a large number of duplicate Classes. It may be necessary to redesign how to reduce duplicate classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor PG/OG statement inheritance relationship [shardingsphere]

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #28728:
URL: https://github.com/apache/shardingsphere/issues/28728#issuecomment-1782439513

   @zihaoAK47 
   It is in the 2.0 documentation ([link](https://docs.opengauss.org/zh/docs/2.0.0/docs/Developerguide/ALTER-RULE.html))
   
   In fact, openGauss has so many similarities with PostgreSQL (SQL protocol and syntax), so we should sort out the common parts and reuse them in ShardingSphere. 
   At the same time, since some statements do not belong to the SQL standards, they should be placed under the PostgreSQL extension.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor PG/OG statement inheritance relationship [shardingsphere]

Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on issue #28728:
URL: https://github.com/apache/shardingsphere/issues/28728#issuecomment-1782450366

   > @zihaoAK47 It is in the 2.0 documentation ([link](https://docs.opengauss.org/zh/docs/2.0.0/docs/Developerguide/ALTER-RULE.html))
   > 
   > In fact, openGauss has so many similarities with PostgreSQL (SQL protocol and syntax), so we should sort out the common parts and reuse them in ShardingSphere. At the same time, since some statements do not belong to the SQL standards, they should be placed under the PostgreSQL extension.
   
   Thank you for your reply. I understand


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor PG/OG statement inheritance relationship [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #28728:
URL: https://github.com/apache/shardingsphere/issues/28728#issuecomment-1826883548

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor PG/OG statement inheritance relationship [shardingsphere]

Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on issue #28728:
URL: https://github.com/apache/shardingsphere/issues/28728#issuecomment-1782366556

   Hi, can I take a look at this question? Thank you
   
   Before starting to solve the problem, I have some doubts about the OpenGaussAlterRuleStatement inheriting from PostgreSQLAlterRuleExtension on the graph
   Alter RULE is an extension of PostgreSQL statements. Why should OpenGaussAlterRuleStatement inherit from PostgreSQLAlterRuleExtension?
   Does this indicate that the OpenGaussAlterRuleStatement dialect is based on an extension of PostgreSQL?
   Additionally, I did not find a description of the Alter RULE statement on the official OpenGauss documentation, as this SQL statement does not seem to belong to the dialect of OpenGauss
   
   [
   ![141102](https://github.com/apache/shardingsphere/assets/106047330/6e0c749b-49a0-4eba-8a84-2df44dc2eeef)
   ](url)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org