You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2023/04/01 00:36:34 UTC

[GitHub] [ozone] hemantk-12 opened a new pull request, #4513: HDDS-8015. [Snapshot] Remove RequestValidations#createValidationRequest

hemantk-12 opened a new pull request, #4513:
URL: https://github.com/apache/ozone/pull/4513

   ## What changes were proposed in this pull request?
   
   This change is to remove `RequestValidations#createValidationRequest` which was added to make snapshotId unique across all the OM nodes. Better way is to set snapshotId inside `OMSnapshotCreateRequest#preExecute` as it is done for other OmRequests like CreateVolume, CreateKey ...etc.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-8015
   
   ## How was this patch tested?
   Existing unit test: `TestOmSnapshot#testUniqueSnapshotId`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] duongkame commented on pull request #4513: HDDS-8015. [Snapshot] Remove RequestValidations#createValidationRequest

Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on PR #4513:
URL: https://github.com/apache/ozone/pull/4513#issuecomment-1502208514

   Thanks @hemantk-12 for the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] duongkame merged pull request #4513: HDDS-8015. [Snapshot] Remove RequestValidations#createValidationRequest

Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame merged PR #4513:
URL: https://github.com/apache/ozone/pull/4513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org