You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Volker Karlmeier <vo...@magiccode.eu> on 2008/11/16 21:11:05 UTC
[PATCH] only in debug-mode: when entityURL is null, it cannot be
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Index:
/home/volker/workspace/commons-digester/src/java/org/apache/commons/digester/Digester.java
===================================================================
- ---
/home/volker/workspace/commons-digester/src/java/org/apache/commons/digester/Digester.java
(revision 718060)
+++
/home/volker/workspace/commons-digester/src/java/org/apache/commons/digester/Digester.java
(working copy)
@@ -1599,7 +1599,10 @@
~ if (systemId == null) {
~ // cannot resolve
~ if (log.isDebugEnabled()) {
- - log.debug(" Cannot resolve entity: '" + entityURL
+ "'");
+ if (entityURL == null)
+ log.debug(" Cannot resolve entity: entityURL is
null");
+ else
+ log.debug(" Cannot resolve entity: '" +
entityURL + "'");
~ }
~ return (null);
- --
- -------------------------------
Volker Karlmeier
Friedrich-Freye-Str. 61
45481 Mülheim/Ruhr
Tel. : (+49) 208-7785675
Mobil: (+49) 176-21056587
Mail : Volker@magiccode.eu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFJIH5ZaEMQXBIqssERAn18AJ4qPN8FNtyKRF+wboq+DMDPNCB1kwCgj4N1
oV3ZDsRrDcY3KHBEopu+YI4=
=JRPQ
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [PATCH] only in debug-mode: when entityURL is null, it cannot be
Posted by sebb <se...@gmail.com>.
Thanks for the patches you have been sending, however the proper place
for these is via a JIRA issue.
It's much easier to keep track of patches via Jira - e-mails can
easily get overlooked, and it can be hard to find the patches if they
are not dealt with immediately.
Please could you create JIRA issues and attach the patches?
Make sure you grant the ASF the licence to use them.
See
https://issues.apache.org/jira/browse/DIGESTER
Thanks very much.
On 16/11/2008, Volker Karlmeier <vo...@magiccode.eu> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Index:
> /home/volker/workspace/commons-digester/src/java/org/apache/commons/digester/Digester.java
> ===================================================================
> - ---
> /home/volker/workspace/commons-digester/src/java/org/apache/commons/digester/Digester.java
> (revision 718060)
> +++
> /home/volker/workspace/commons-digester/src/java/org/apache/commons/digester/Digester.java
> (working copy)
> @@ -1599,7 +1599,10 @@
> ~ if (systemId == null) {
> ~ // cannot resolve
> ~ if (log.isDebugEnabled()) {
> - - log.debug(" Cannot resolve entity: '" + entityURL +
> "'");
> + if (entityURL == null)
> + log.debug(" Cannot resolve entity: entityURL is
> null");
> + else
> + log.debug(" Cannot resolve entity: '" + entityURL
> + "'");
> ~ }
> ~ return (null);
>
>
> - --
> - -------------------------------
>
> Volker Karlmeier
> Friedrich-Freye-Str. 61
> 45481 Mülheim/Ruhr
>
> Tel. : (+49) 208-7785675
> Mobil: (+49) 176-21056587
> Mail : Volker@magiccode.eu
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
>
> iD8DBQFJIH5ZaEMQXBIqssERAn18AJ4qPN8FNtyKRF+wboq+DMDPNCB1kwCgj4N1
> oV3ZDsRrDcY3KHBEopu+YI4=
> =JRPQ
> -----END PGP SIGNATURE-----
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org