You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "alvinzhangdd (via GitHub)" <gi...@apache.org> on 2023/12/07 22:34:13 UTC
[I] [Helm Chart] Fix server liveness, readiness probe endpoint not backward compatible [pinot]
alvinzhangdd opened a new issue, #12113:
URL: https://github.com/apache/pinot/issues/12113
Made this change previously https://github.com/apache/pinot/pull/11800
But it is not backward compatible, if someone uses the following in their helm template:
```
probes:
livenessEnabled: true
readinessEnabled: true
```
It will throw error:
Error: INSTALLATION FAILED: template: pinot-v2/charts/pinot/templates/server/statefulset.yaml:93:26: executing "pinot-v2/charts/pinot/templates/server/statefulset.yaml" at <.Values.server.probes.livenessProbe.endpoint>: nil pointer evaluating interface {}.endpoint
It is because the previous commit uses `{{- if .Values.server.probes.readinessProbe.endpoint }}` but never checked the existence of `.Values.server.probes.readinessProbe`
The above template setting should fall back to use `.Values.server.probes.endpoint` instead of throwing error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Helm Chart] Fix server liveness, readiness probe endpoint not backward compatible [pinot]
Posted by "alvinzhangdd (via GitHub)" <gi...@apache.org>.
alvinzhangdd commented on issue #12113:
URL: https://github.com/apache/pinot/issues/12113#issuecomment-1846235205
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Helm Chart] Fix server liveness, readiness probe endpoint not backward compatible [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #12113:
URL: https://github.com/apache/pinot/issues/12113#issuecomment-1846229515
would you like to create a fix for this soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Helm Chart] Fix server liveness, readiness probe endpoint not backward compatible [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #12113: [Helm Chart] Fix server liveness, readiness probe endpoint not backward compatible
URL: https://github.com/apache/pinot/issues/12113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Helm Chart] Fix server liveness, readiness probe endpoint not backward compatible [pinot]
Posted by "alvinzhangdd (via GitHub)" <gi...@apache.org>.
alvinzhangdd commented on issue #12113:
URL: https://github.com/apache/pinot/issues/12113#issuecomment-1846247104
@walterddr created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org