You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/24 22:24:03 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #2483: Prevent NullPointerException from LSP HyperlinkProvider
matthiasblaesing opened a new pull request #2483:
URL: https://github.com/apache/netbeans/pull/2483
The LSP HyperlinkProvider is registered for every document. It expects,
that documents always provide token sequences. This assumption is
invalid and the calls need to be guarded agains null token sequences.
Observed backtrace:
SEVERE [global]
java.lang.NullPointerException
at org.netbeans.modules.lsp.client.bindings.HyperlinkProviderImpl.getHyperlinkSpan(HyperlinkProviderImpl.java:76)
at org.netbeans.modules.lsp.client.bindings.HyperlinkProviderImpl.isHyperlinkPoint(HyperlinkProviderImpl.java:62)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.findProvider(HyperlinkOperation.java:266)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.performHyperlinking(HyperlinkOperation.java:224)
at org.netbeans.lib.editor.hyperlink.HyperlinkOperation.keyPressed(HyperlinkOperation.java:382)
at java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:258)
at java.desktop/java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:257)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2483: Prevent NullPointerException from LSP HyperlinkProvider
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2483:
URL: https://github.com/apache/netbeans/pull/2483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2483: Prevent NullPointerException from LSP HyperlinkProvider
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2483:
URL: https://github.com/apache/netbeans/pull/2483#issuecomment-716063697
The stacktrace mentioned above was observed when editing properties files, but I was also able to reproduce it with a simple txt file. Just open a "txt" file, edit and try to save it. You will see a NullPointerException being reported.
With a debugger it can be observed, that the HyperlinkProviderImpl in the lsp.client project is invoked, tries to get the token sequence from the document, gets null and fails.
I consider this a release blocker, so this should go into delivery before we release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists