You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/05/11 09:44:11 UTC
[PR] [MINOR][INFRA][4.x] Fix `branch` input default in build_and_test.yml [spark]
zhengruifeng opened a new pull request, #55797:
URL: https://github.com/apache/spark/pull/55797
### What changes were proposed in this pull request?
Update the default value of the `branch` workflow input in `.github/workflows/build_and_test.yml` from `master` to `branch-4.x`, and drop the stale `# Change 'master' to 'branch-4.0' in branch-4.0 branch after cutting it.` comment.
### Why are the changes needed?
When `branch-4.x` was cut from master, the comment in `build_and_test.yml` flagged that the default should be updated, but it wasn't. As a result, the `Build` workflow on pushes to `branch-4.x` invokes the reusable `build_and_test.yml` without an explicit `branch` input, which falls back to the default `master`. The `precondition` job then runs `actions/checkout` with `ref: master` against `apache/spark`, so the CI tests `master` rather than `branch-4.x`.
The same misconfiguration was observed on `branch-4.2` ([example CI run](https://github.com/apache/spark/actions/runs/25591666487/job/75130390722)) and is fixed there in a sibling PR. The same fix was already applied on `branch-4.0` and `branch-4.1`.
### Does this PR introduce _any_ user-facing change?
No. CI-only.
### How was this patch tested?
GitHub Actions on this PR. The default takes effect on subsequent pushes to `branch-4.x`.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA][4.x] Fix `branch` input default in build_and_test.yml [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #55797: [MINOR][INFRA][4.x] Fix `branch` input default in build_and_test.yml
URL: https://github.com/apache/spark/pull/55797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][INFRA][4.x] Fix `branch` input default in build_and_test.yml [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #55797:
URL: https://github.com/apache/spark/pull/55797#issuecomment-4420264014
merged to 4.x to enable the post-merge ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org