You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by fu...@apache.org on 2007/12/18 03:20:35 UTC
svn commit: r605066 - /httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Author: fuankg
Date: Mon Dec 17 18:20:33 2007
New Revision: 605066
URL: http://svn.apache.org/viewvc?rev=605066&view=rev
Log:
added placeholder for module load.
Modified:
httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Modified: httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf?rev=605066&r1=605065&r2=605066&view=diff
==============================================================================
--- httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf (original)
+++ httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf Mon Dec 17 18:20:33 2007
@@ -2,6 +2,8 @@
# Sample configuration file for the FTP protocol module.
#########################################################################
+#@@LoadModule@@
+
#########################################################################
# Basic setup
#########################################################################
Re: svn commit: r605066 -
/httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Posted by Guenter Knauf <fu...@apache.org>.
Hi Bill,
> Keep in mind we can't use @@LoadModules@@ though - not with a in tree
> build.
aah yes, true.
> What about @@LoadFtpModules@@ instead? If that's the preference, I don't
> mind changing the unix/win32 direction either.
fine - I've changed as you suggested.
>> how about other replacements to come closer to what we have in
>> httpd.conf.in / ssl.conf.in ?
>>
>> f.e. s/\/logs\//\/@exp_logfiledir@\//g and so on (path to certs etc.),
>> and quoting these also?
> +1; I don't see it as a 0.9.1 beta showstopper, but it would be great.
done, please check if I did it right - I'm a bit short in time at the moment, and can only look later again into it....
Guen.
Re: svn commit: r605066 - /httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> Hi Bill,
>> Any concerns with my new approach?
> no real concerns - but personally I would prefer to have the load statements inside each conf file;
> also because for now we anyway distribute it separately, and once we have it inside httpd then anyway things might go other ways - f.e. I till then merge my separate awk script into the main one we use for all other confs...; also keep in mind that normally I cant process the httpd.conf in use, nor install into a running httpd place; I have to create distribution-like archives for NetWare;
> expect 99.9% of the users use a binary distribution, and I think for Win32 it might also 95+% probably...
> If possible I would like to have that in for now which makes it easier to replace - I commented it so that it cant hurt elsewhere; but if you want to remove then ok...
Keep in mind we can't use @@LoadModules@@ though - not with a in tree build.
What about @@LoadFtpModules@@ instead? If that's the preference, I don't
mind changing the unix/win32 direction either.
> how about other replacements to come closer to what we have in httpd.conf.in / ssl.conf.in ?
>
> f.e. s/\/logs\//\/@exp_logfiledir@\//g and so on (path to certs etc.), and quoting these also?
+1; I don't see it as a 0.9.1 beta showstopper, but it would be great.
Re: svn commit: r605066 -
/httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Posted by Guenter Knauf <fu...@apache.org>.
Hi Bill,
> Any concerns with my new approach?
no real concerns - but personally I would prefer to have the load statements inside each conf file;
also because for now we anyway distribute it separately, and once we have it inside httpd then anyway things might go other ways - f.e. I till then merge my separate awk script into the main one we use for all other confs...; also keep in mind that normally I cant process the httpd.conf in use, nor install into a running httpd place; I have to create distribution-like archives for NetWare;
expect 99.9% of the users use a binary distribution, and I think for Win32 it might also 95+% probably...
If possible I would like to have that in for now which makes it easier to replace - I commented it so that it cant hurt elsewhere; but if you want to remove then ok...
> FYI - the example cwd module is really cheesy, really we don't need
> or want to build or install that by default.
ok.
how about other replacements to come closer to what we have in httpd.conf.in / ssl.conf.in ?
f.e. s/\/logs\//\/@exp_logfiledir@\//g and so on (path to certs etc.), and quoting these also?
Guen.
Re: svn commit: r605066 - /httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Guenter,
>
> see the logic in (top level) Makefile.apxs which invokes the
> build/addloadexample.awk script (I recall you can rely on an awk
> being present.)
Oh - we need to add a -v DSO=.nlm - I've already adjusted Makefile.apxs
accordingly.
Re: svn commit: r605066 - /httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter,
see the logic in (top level) Makefile.apxs which invokes the
build/addloadexample.awk script (I recall you can rely on an awk
being present.)
Rather than loading the module inside extra/ftpd.conf, I coupled
it in 'in the style of' the other extra/*.conf sections, and the new
awk script finds the first blank after the LoadModule sequence to fill
in the blank, and appends the #Include extra/ftpd.conf statement to
the very end of the httpd.conf.
Any concerns with my new approach?
FYI - the example cwd module is really cheesy, really we don't need
or want to build or install that by default.
Bill
fuankg@apache.org wrote:
> Author: fuankg
> Date: Mon Dec 17 18:20:33 2007
> New Revision: 605066
>
> URL: http://svn.apache.org/viewvc?rev=605066&view=rev
> Log:
> added placeholder for module load.
>
> --- httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf (original)
> +++ httpd/mod_ftp/trunk/docs/conf/extra/ftpd.conf Mon Dec 17 18:20:33 2007
> @@ -2,6 +2,8 @@
> # Sample configuration file for the FTP protocol module.
> #########################################################################
>
> +#@@LoadModule@@
> +
> #########################################################################
> # Basic setup
> #########################################################################
>
>
>
>