You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "dao-jun (via GitHub)" <gi...@apache.org> on 2024/03/11 19:10:15 UTC
[PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
dao-jun opened a new pull request, #22246:
URL: https://github.com/apache/pulsar/pull/22246
### Motivation
Code clean up.
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-2023350157
@lhotari
> It seems that this was merged without more reviews
Yes, my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun closed pull request #22246: [cleanup][ml] ManagedCursor clean up.
URL: https://github.com/apache/pulsar/pull/22246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-1993606510
Hi @dao-jun Could you merge the pr at least two reviews approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-1993629522
@dao-jun The PR touched the critical path of Pulsar, we should wait for more reviewers to review the PR. If a PR get merged with one reviewer and merged in a few hours, the committers will lost the chance to review your PR and new potential risks might introduce to the Pulsar codebase. Now, so many companies are relaying on the stable release, even if this is a trivial changes to cleanup the managed cursor, give more time for other reviewer will still benefit Pulsar. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-2022537459
> > @dao-jun The PR touched the critical path of Pulsar, we should wait for more reviewers to review the PR. If a PR get merged with one reviewer and merged in a few hours, the committers will lost the chance to review your PR and new potential risks might introduce to the Pulsar codebase. Now, so many companies are relaying on the stable release, even if this is a trivial changes to cleanup the managed cursor, give more time for other reviewer will still benefit Pulsar. WDYT?
>
> got it
@dao-jun It seems that this was merged without more reviews. I added a comment to the commit:
https://github.com/apache/pulsar/commit/532b0d9063474bd1c7ae8ac7cf5bd2d56b002164#r140287388
> does this change have a side-effect where it creates PositionImpl objects? A lot of effort has been put into reducing object allocations so that's why this could be causing a regression in that area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun closed pull request #22246: [cleanup][ml] ManagedCursor clean up.
URL: https://github.com/apache/pulsar/pull/22246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-2023375730
> > It seems that this was merged without more reviews
>
> Yes, my bad
@dao-jun I'd recommend reverting the change that I have pinpointed in the comment https://github.com/apache/pulsar/commit/532b0d9063474bd1c7ae8ac7cf5bd2d56b002164#r140287388 , assuming that it creates new PositionImpl instances which were avoided before this change was made. /cc @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun merged PR #22246:
URL: https://github.com/apache/pulsar/pull/22246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-2023414058
@lhotari I've replied your comment, https://github.com/apache/pulsar/commit/532b0d9063474bd1c7ae8ac7cf5bd2d56b002164#r140303950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-1990908230
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 73.60%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`27f0f78`)](https://app.codecov.io/gh/apache/pulsar/pull/22246?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 36 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/22246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #22246 +/- ##
============================================
+ Coverage 73.57% 73.60% +0.02%
- Complexity 32624 32754 +130
============================================
Files 1877 1879 +2
Lines 139502 139791 +289
Branches 15299 15335 +36
============================================
+ Hits 102638 102892 +254
- Misses 28908 28914 +6
- Partials 7956 7985 +29
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22246/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.50% <71.42%> (+1.91%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/22246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.31% <85.71%> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.88% <100.00%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/22246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/bookkeeper/mledger/impl/EntryImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL0VudHJ5SW1wbC5qYXZh) | `79.26% <100.00%> (+0.78%)` | :arrow_up: |
| [...che/bookkeeper/mledger/impl/ManagedCursorImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRDdXJzb3JJbXBsLmphdmE=) | `79.12% <100.00%> (-0.18%)` | :arrow_down: |
... and [73 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22246/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [cleanup][ml] ManagedCursor clean up. [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #22246:
URL: https://github.com/apache/pulsar/pull/22246#issuecomment-1994002755
> @dao-jun The PR touched the critical path of Pulsar, we should wait for more reviewers to review the PR. If a PR get merged with one reviewer and merged in a few hours, the committers will lost the chance to review your PR and new potential risks might introduce to the Pulsar codebase. Now, so many companies are relaying on the stable release, even if this is a trivial changes to cleanup the managed cursor, give more time for other reviewer will still benefit Pulsar. WDYT?
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org