[jira] [Commented] (ATLAS-834) Handle exceptions from HiveHook executor.submit()

["ATLAS QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304708#comment-15304708 ] 

ATLAS QA commented on ATLAS-834:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12806691/ATLAS-834.patch
  against master revision 0143486.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 379 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/262//console

This message is automatically generated.

> Handle exceptions from HiveHook executor.submit()
> -------------------------------------------------
>
>                 Key: ATLAS-834
>                 URL: https://issues.apache.org/jira/browse/ATLAS-834
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 0.6-incubating, 0.7-incubating
>            Reporter: Shwetha G S
>            Assignee: Suma Shivaprasad
>            Priority: Critical
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-834.patch
>
>
> Atlas hive hook uses threadpool with fixed queue size(to restrict memory). In cases of high load, all threads may be busy and queue may be full in which case, threadpool.submit() fails and hive command execution fails. We should ignore this failure(will result in loss of data for atlas, but we don't have any store forward solution) and let the hive command execution complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)