You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by shen guoquan <gu...@intel.com> on 2015/03/03 03:20:40 UTC
Review Request 31657: SENTRY-644: Sentry Sqoop binding framework for
role-based authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs
-----
pom.xml 4c80916
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml PRE-CREATION
sentry-dist/pom.xml f63b33b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On March 28, 2015, 12:30 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/pom.xml, line 72
> > <https://reviews.apache.org/r/31657/diff/4/?file=906563#file906563line72>
> >
> > Should not depend on sqoop-core.
heads up... we're having some discussions in Sqoop about this.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78133
-----------------------------------------------------------
On March 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On March 28, 2015, 12:30 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/pom.xml, line 72
> > <https://reviews.apache.org/r/31657/diff/4/?file=906563#file906563line72>
> >
> > Should not depend on sqoop-core.
heads up... we're having some discussions in Sqoop about this.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78133
-----------------------------------------------------------
On March 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 28, 2015, 12:30 a.m., Abraham Elmahrek wrote:
> > I do have one high level comment about Sqoop integration. Sqoop-core is not intended to be depended on. So perhaps we can file a Jira with the Sqoop community to fix?
Hi abe. Thanks for your review and comment. I think the sentry was integrated into the sqoop server. The sqoop client will not require the sentry library. The sentry will need to depend on the sqoop-core package. It will need to use the AuthorizationHandler and AuthenticationHandler these classes. If it does not allow to depend on the core package. May be it will be a little difficult to integration. Thanks. I am looking forward to your comments.
> On 三月 28, 2015, 12:30 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/pom.xml, line 72
> > <https://reviews.apache.org/r/31657/diff/4/?file=906563#file906563line72>
> >
> > Should not depend on sqoop-core.
>
> Abraham Elmahrek wrote:
> heads up... we're having some discussions in Sqoop about this.
Thanks for your comment. I will fix it. But The sentry will depend on the sqoop-server package. The sqoop-server is depend on the sqoop-core. So the sentry is indirectly depend on the sqoop-core.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78133
-----------------------------------------------------------
On 三月 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 28, 2015, 12:30 a.m., Abraham Elmahrek wrote:
> > I do have one high level comment about Sqoop integration. Sqoop-core is not intended to be depended on. So perhaps we can file a Jira with the Sqoop community to fix?
Hi abe. Thanks for your review and comment. I think the sentry was integrated into the sqoop server. The sqoop client will not require the sentry library. The sentry will need to depend on the sqoop-core package. It will need to use the AuthorizationHandler and AuthenticationHandler these classes. If it does not allow to depend on the core package. May be it will be a little difficult to integration. Thanks. I am looking forward to your comments.
> On 三月 28, 2015, 12:30 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/pom.xml, line 72
> > <https://reviews.apache.org/r/31657/diff/4/?file=906563#file906563line72>
> >
> > Should not depend on sqoop-core.
>
> Abraham Elmahrek wrote:
> heads up... we're having some discussions in Sqoop about this.
Thanks for your comment. I will fix it. But The sentry will depend on the sqoop-server package. The sqoop-server is depend on the sqoop-core. So the sentry is indirectly depend on the sqoop-core.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78133
-----------------------------------------------------------
On 三月 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78133
-----------------------------------------------------------
I do have one high level comment about Sqoop integration. Sqoop-core is not intended to be depended on. So perhaps we can file a Jira with the Sqoop community to fix?
sentry-binding/sentry-binding-sqoop/pom.xml
<https://reviews.apache.org/r/31657/#comment126617>
Should not depend on sqoop-core.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment126618>
Instead of including core, create a sqoop bug to move this to sqoop-common module?
- Abraham Elmahrek
On March 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 28, 2015, 1:02 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 42
> > <https://reviews.apache.org/r/31657/diff/4/?file=906568#file906568line42>
> >
> > It seems a lot of this was done in DefaultAuthorizationHandler in Sqoop2. Maybe you can just extend it or re-use it completely?
Good advice. I will change it.
> On 三月 28, 2015, 1:02 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, lines 99-109
> > <https://reviews.apache.org/r/31657/diff/4/?file=906568#file906568line99>
> >
> > Why not just re-use SecurityFactory in sqoop? Maybe this is for testing? Seems like a weird usability thing to use a different configuration in Sqoop2.
Ok, I will fix it. Thanks
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78140
-----------------------------------------------------------
On 三月 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 28, 2015, 1:02 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 42
> > <https://reviews.apache.org/r/31657/diff/4/?file=906568#file906568line42>
> >
> > It seems a lot of this was done in DefaultAuthorizationHandler in Sqoop2. Maybe you can just extend it or re-use it completely?
Good advice. I will change it.
> On 三月 28, 2015, 1:02 a.m., Abraham Elmahrek wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, lines 99-109
> > <https://reviews.apache.org/r/31657/diff/4/?file=906568#file906568line99>
> >
> > Why not just re-use SecurityFactory in sqoop? Maybe this is for testing? Seems like a weird usability thing to use a different configuration in Sqoop2.
Ok, I will fix it. Thanks
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78140
-----------------------------------------------------------
On 三月 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78140
-----------------------------------------------------------
And a quick follow up...
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment126624>
It seems a lot of this was done in DefaultAuthorizationHandler in Sqoop2. Maybe you can just extend it or re-use it completely?
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment126622>
Why not just re-use SecurityFactory in sqoop? Maybe this is for testing? Seems like a weird usability thing to use a different configuration in Sqoop2.
- Abraham Elmahrek
On March 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 四月 16, 2015, 10:47 p.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java, line 86
> > <https://reviews.apache.org/r/31657/diff/5/?file=918735#file918735line86>
> >
> > The new object is never assigned to instance. It will always be null.
I am sorry for that mistake. I will fix it. Thanks Prasad
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80389
-----------------------------------------------------------
On 四月 7, 2015, 3:29 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 四月 7, 2015, 3:29 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 0cfe260
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 5ebfa69
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 四月 16, 2015, 10:47 p.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java, line 86
> > <https://reviews.apache.org/r/31657/diff/5/?file=918735#file918735line86>
> >
> > The new object is never assigned to instance. It will always be null.
I am sorry for that mistake. I will fix it. Thanks Prasad
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80389
-----------------------------------------------------------
On 四月 7, 2015, 3:29 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 四月 7, 2015, 3:29 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 0cfe260
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 5ebfa69
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80389
-----------------------------------------------------------
Looks fine, just one comment below
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java
<https://reviews.apache.org/r/31657/#comment130281>
The new object is never assigned to instance. It will always be null.
- Prasad Mujumdar
On April 7, 2015, 3:29 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 3:29 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 0cfe260
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 5ebfa69
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80389
-----------------------------------------------------------
Looks fine, just one comment below
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java
<https://reviews.apache.org/r/31657/#comment130281>
The new object is never assigned to instance. It will always be null.
- Prasad Mujumdar
On April 7, 2015, 3:29 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 3:29 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 0cfe260
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 5ebfa69
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review81580
-----------------------------------------------------------
Ship it!
Small nit :).
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment132015>
Hey this is named incorrectly: SentryAuthorizationHandler seems more right (missing the 'l' in Handler).
Also, it seems sqoop has a capital A in Authorization. I'll get on top of that in the Sqoop community.
- Abraham Elmahrek
On April 17, 2015, 2:42 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated April 17, 2015, 2:42 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 90ecea1
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 51e05a5
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80433
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On April 17, 2015, 2:42 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated April 17, 2015, 2:42 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 90ecea1
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 51e05a5
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review81580
-----------------------------------------------------------
Ship it!
Small nit :).
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment132015>
Hey this is named incorrectly: SentryAuthorizationHandler seems more right (missing the 'l' in Handler).
Also, it seems sqoop has a capital A in Authorization. I'll get on top of that in the Sqoop community.
- Abraham Elmahrek
On April 17, 2015, 2:42 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated April 17, 2015, 2:42 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 90ecea1
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 51e05a5
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review80433
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On April 17, 2015, 2:42 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated April 17, 2015, 2:42 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 90ecea1
> sentry-binding/pom.xml b903ab3
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml 51e05a5
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated April 17, 2015, 2:42 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 90ecea1
sentry-binding/pom.xml b903ab3
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml 51e05a5
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated April 17, 2015, 2:42 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 90ecea1
sentry-binding/pom.xml b903ab3
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml 51e05a5
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 四月 7, 2015, 3:29 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 0cfe260
sentry-binding/pom.xml b903ab3
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml 5ebfa69
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78133
-----------------------------------------------------------
I do have one high level comment about Sqoop integration. Sqoop-core is not intended to be depended on. So perhaps we can file a Jira with the Sqoop community to fix?
sentry-binding/sentry-binding-sqoop/pom.xml
<https://reviews.apache.org/r/31657/#comment126617>
Should not depend on sqoop-core.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment126618>
Instead of including core, create a sqoop bug to move this to sqoop-common module?
- Abraham Elmahrek
On March 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 四月 7, 2015, 3:29 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 0cfe260
sentry-binding/pom.xml b903ab3
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml 5ebfa69
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review78140
-----------------------------------------------------------
And a quick follow up...
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment126624>
It seems a lot of this was done in DefaultAuthorizationHandler in Sqoop2. Maybe you can just extend it or re-use it completely?
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment126622>
Why not just re-use SecurityFactory in sqoop? Maybe this is for testing? Seems like a weird usability thing to use a different configuration in Sqoop2.
- Abraham Elmahrek
On March 26, 2015, 8:54 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:54 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f7a663b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 26, 2015, 8:54 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 2f97880
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml f7a663b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 57
> > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line57>
> >
> > Does this need to be info ? I am not sure how often sqoop calls this. It might be too much noise in the log file.
Thanks for your advice. I will fix it
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 66
> > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line66>
> >
> > Should this be InstantiationException ?
Good suggestion. I will change
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 92
> > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line92>
> >
> > It would be great if SqoopConfig could directly indentify if strong authorization is enabled rather than Sentry figuring out that from sqoop config.
> > Let's work with Sqoop comminuty to make this into an API in future.
I agree with you. I will told richard to response this situation.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java, line 60
> > <https://reviews.apache.org/r/31657/diff/3/?file=898555#file898555line60>
> >
> > " does not have privilege for action " ?
I will fix it.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, line 351
> > <https://reviews.apache.org/r/31657/diff/3/?file=898556#file898556line351>
> >
> > Nit: formatting.
Thanks for your reminder.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, line 382
> > <https://reviews.apache.org/r/31657/diff/3/?file=898556#file898556line382>
> >
> > Is there a reason we don't pass the full exception to SqoopException() ?
I will put the full exception to SqoopException. Thanks for your suggestion
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review77299
-----------------------------------------------------------
On 三月 18, 2015, 2:14 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 18, 2015, 2:14 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 57
> > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line57>
> >
> > Does this need to be info ? I am not sure how often sqoop calls this. It might be too much noise in the log file.
Thanks for your advice. I will fix it
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 66
> > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line66>
> >
> > Should this be InstantiationException ?
Good suggestion. I will change
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 92
> > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line92>
> >
> > It would be great if SqoopConfig could directly indentify if strong authorization is enabled rather than Sentry figuring out that from sqoop config.
> > Let's work with Sqoop comminuty to make this into an API in future.
I agree with you. I will told richard to response this situation.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java, line 60
> > <https://reviews.apache.org/r/31657/diff/3/?file=898555#file898555line60>
> >
> > " does not have privilege for action " ?
I will fix it.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, line 351
> > <https://reviews.apache.org/r/31657/diff/3/?file=898556#file898556line351>
> >
> > Nit: formatting.
Thanks for your reminder.
> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, line 382
> > <https://reviews.apache.org/r/31657/diff/3/?file=898556#file898556line382>
> >
> > Is there a reason we don't pass the full exception to SqoopException() ?
I will put the full exception to SqoopException. Thanks for your suggestion
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review77299
-----------------------------------------------------------
On 三月 18, 2015, 2:14 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 18, 2015, 2:14 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review77299
-----------------------------------------------------------
Looks fine. Some minor comments below.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment125196>
Does this need to be info ? I am not sure how often sqoop calls this. It might be too much noise in the log file.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment125199>
Should this be InstantiationException ?
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment125200>
It would be great if SqoopConfig could directly indentify if strong authorization is enabled rather than Sentry figuring out that from sqoop config.
Let's work with Sqoop comminuty to make this into an API in future.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java
<https://reviews.apache.org/r/31657/#comment125201>
" does not have privilege for action " ?
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
<https://reviews.apache.org/r/31657/#comment125243>
Nit: formatting.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
<https://reviews.apache.org/r/31657/#comment125240>
Is there a reason we don't pass the full exception to SqoopException() ?
- Prasad Mujumdar
On March 18, 2015, 2:14 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 2:14 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review77299
-----------------------------------------------------------
Looks fine. Some minor comments below.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment125196>
Does this need to be info ? I am not sure how often sqoop calls this. It might be too much noise in the log file.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment125199>
Should this be InstantiationException ?
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment125200>
It would be great if SqoopConfig could directly indentify if strong authorization is enabled rather than Sentry figuring out that from sqoop config.
Let's work with Sqoop comminuty to make this into an API in future.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java
<https://reviews.apache.org/r/31657/#comment125201>
" does not have privilege for action " ?
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
<https://reviews.apache.org/r/31657/#comment125243>
Nit: formatting.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
<https://reviews.apache.org/r/31657/#comment125240>
Is there a reason we don't pass the full exception to SqoopException() ?
- Prasad Mujumdar
On March 18, 2015, 2:14 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 2:14 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 26, 2015, 8:54 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 2f97880
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml f7a663b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 18, 2015, 2:14 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 4c80916
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml f63b33b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 18, 2015, 2:14 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 4c80916
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml f63b33b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 10, 2015, 7:17 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 4c80916
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml f63b33b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 57
> > <https://reviews.apache.org/r/31657/diff/1/?file=882549#file882549line57>
> >
> > The actual AccessController should be configured in conf file.
Thanks colin for your advice. I will fix it
> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java, line 32
> > <https://reviews.apache.org/r/31657/diff/1/?file=882547#file882547line32>
> >
> > When using policy file, the result of following methods are not correct:
> > getAllRoles
> > getPrincipalsByRole
> > getRolesByPrincipal
If sqoop useing policy file as backend, these commands make no sense.
> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, line 137
> > <https://reviews.apache.org/r/31657/diff/1/?file=882551#file882551line137>
> >
> > The method is not necessary.
Yeah, I will fix it. Thanks for your comment
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review75297
-----------------------------------------------------------
On 三月 5, 2015, 2:36 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:36 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, line 57
> > <https://reviews.apache.org/r/31657/diff/1/?file=882549#file882549line57>
> >
> > The actual AccessController should be configured in conf file.
Thanks colin for your advice. I will fix it
> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java, line 32
> > <https://reviews.apache.org/r/31657/diff/1/?file=882547#file882547line32>
> >
> > When using policy file, the result of following methods are not correct:
> > getAllRoles
> > getPrincipalsByRole
> > getRolesByPrincipal
If sqoop useing policy file as backend, these commands make no sense.
> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote:
> > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, line 137
> > <https://reviews.apache.org/r/31657/diff/1/?file=882551#file882551line137>
> >
> > The method is not necessary.
Yeah, I will fix it. Thanks for your comment
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review75297
-----------------------------------------------------------
On 三月 5, 2015, 2:36 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:36 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review75297
-----------------------------------------------------------
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java
<https://reviews.apache.org/r/31657/#comment122280>
When using policy file, the result of following methods are not correct:
getAllRoles
getPrincipalsByRole
getRolesByPrincipal
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment122283>
The actual AccessController should be configured in conf file.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
<https://reviews.apache.org/r/31657/#comment122284>
The method is not necessary.
- Colin Ma
On March 5, 2015, 2:36 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:36 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/#review75297
-----------------------------------------------------------
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java
<https://reviews.apache.org/r/31657/#comment122280>
When using policy file, the result of following methods are not correct:
getAllRoles
getPrincipalsByRole
getRolesByPrincipal
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java
<https://reviews.apache.org/r/31657/#comment122283>
The actual AccessController should be configured in conf file.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
<https://reviews.apache.org/r/31657/#comment122284>
The method is not necessary.
- Colin Ma
On March 5, 2015, 2:36 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31657/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:36 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry Sqoop binding framework for role-based authorization
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-binding/pom.xml 7428aa5
> sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml PRE-CREATION
> sentry-dist/pom.xml f63b33b
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
>
> Diff: https://reviews.apache.org/r/31657/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 10, 2015, 7:17 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs (updated)
-----
pom.xml 4c80916
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-dist/pom.xml f63b33b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan
Re: Review Request 31657: SENTRY-644: Sentry Sqoop binding framework
for role-based authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31657/
-----------------------------------------------------------
(Updated 三月 5, 2015, 2:36 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Sentry Sqoop binding framework for role-based authorization
Diffs
-----
pom.xml 4c80916
sentry-binding/pom.xml 7428aa5
sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml PRE-CREATION
sentry-dist/pom.xml f63b33b
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java def3486
Diff: https://reviews.apache.org/r/31657/diff/
Testing
-------
Ran unit tests
Thanks,
shen guoquan