You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Markus Jelsma (JIRA)" <ji...@apache.org> on 2012/05/16 11:33:02 UTC
[jira] [Created] (SOLR-3457) Spellchecker always incorrectly
spelled
Markus Jelsma created SOLR-3457:
-----------------------------------
Summary: Spellchecker always incorrectly spelled
Key: SOLR-3457
URL: https://issues.apache.org/jira/browse/SOLR-3457
Project: Solr
Issue Type: Bug
Components: spellchecker
Affects Versions: 4.0
Environment: solr-spec 4.0.0.2012.05.15.11.42.06
solr-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 11:42:06
lucene-spec 4.0-SNAPSHOT
lucene-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 10:51:02
Reporter: Markus Jelsma
correctlySpelled is always false with default configuration, example config and example documents:
http://localhost:8983/solr/collection1/browse?wt=xml&spellcheck.extendedResults=true&q=samsung
{code}
<lst name="spellcheck">
<lst name="suggestions">
<bool name="correctlySpelled">false</bool>
</lst>
</lst>
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3457) Spellchecker always incorrectly
spelled
Posted by "Markus Jelsma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Jelsma updated SOLR-3457:
--------------------------------
Attachment: SOLR-3457-4.0-1.patch
Patch for trunk. It seems the isCorrectlySpelled flag is not correctly initialized. In the example samsun is incorrectly spelled, has freqInfo and zero suggestions so it's never set to true.
> Spellchecker always incorrectly spelled
> ---------------------------------------
>
> Key: SOLR-3457
> URL: https://issues.apache.org/jira/browse/SOLR-3457
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Environment: solr-spec 4.0.0.2012.05.15.11.42.06
> solr-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 11:42:06
> lucene-spec 4.0-SNAPSHOT
> lucene-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 10:51:02
> Reporter: Markus Jelsma
> Attachments: SOLR-3457-4.0-1.patch
>
>
> correctlySpelled is always false with default configuration, example config and example documents:
> http://localhost:8983/solr/collection1/browse?wt=xml&spellcheck.extendedResults=true&q=samsung
> {code}
> <lst name="spellcheck">
> <lst name="suggestions">
> <bool name="correctlySpelled">false</bool>
> </lst>
> </lst>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3457) Spellchecker always incorrectly
spelled
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3457.
------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: James Dyer
Fixed with SOLR-2585 commit (Trunk r1341894).
> Spellchecker always incorrectly spelled
> ---------------------------------------
>
> Key: SOLR-3457
> URL: https://issues.apache.org/jira/browse/SOLR-3457
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Environment: solr-spec 4.0.0.2012.05.15.11.42.06
> solr-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 11:42:06
> lucene-spec 4.0-SNAPSHOT
> lucene-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 10:51:02
> Reporter: Markus Jelsma
> Assignee: James Dyer
> Fix For: 4.0
>
> Attachments: SOLR-3457-4.0-1.patch
>
>
> correctlySpelled is always false with default configuration, example config and example documents:
> http://localhost:8983/solr/collection1/browse?wt=xml&spellcheck.extendedResults=true&q=samsung
> {code}
> <lst name="spellcheck">
> <lst name="suggestions">
> <bool name="correctlySpelled">false</bool>
> </lst>
> </lst>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3457) Spellchecker always incorrectly
spelled
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279162#comment-13279162 ]
James Dyer commented on SOLR-3457:
----------------------------------
I can reproduce this problem running the solr example. The fix looked straighforward but unfortunately it causes 2 of the "SpellCheckComponentTest" cases to fail. The code, unfortunately, is a bit squirrely here.
I'm going to take a look at SOLR-2585 to see if applying that fixes this issue also. SOLR-2585 included rewritten logic for the "correctlySpelled" flag.
> Spellchecker always incorrectly spelled
> ---------------------------------------
>
> Key: SOLR-3457
> URL: https://issues.apache.org/jira/browse/SOLR-3457
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Environment: solr-spec 4.0.0.2012.05.15.11.42.06
> solr-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 11:42:06
> lucene-spec 4.0-SNAPSHOT
> lucene-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 10:51:02
> Reporter: Markus Jelsma
> Attachments: SOLR-3457-4.0-1.patch
>
>
> correctlySpelled is always false with default configuration, example config and example documents:
> http://localhost:8983/solr/collection1/browse?wt=xml&spellcheck.extendedResults=true&q=samsung
> {code}
> <lst name="spellcheck">
> <lst name="suggestions">
> <bool name="correctlySpelled">false</bool>
> </lst>
> </lst>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3457) Spellchecker always incorrectly
spelled
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280554#comment-13280554 ]
James Dyer commented on SOLR-3457:
----------------------------------
I've found this happens with DirectSolrSpellChecker, which the example was migrated to somewhat recently. I have a fix incorporated into SOLR-2585, which I will commit soon unless there are objections. This changes the behavior of "correctlySpelled" slightly. The new behavior sets it to "true" if the user's query has at least 1 hit. The exception to this is if the new "maxResultsForSuggest" parameter is invoked, the value supplied here would be the threshold hits that flips "correctlySpelled". All tests pass with this logic change.
My feeling is that possibly in the past certain proxy metrics were used to determine if FileBasedSpellChecker was being used and if so, "correctlySpelled" was supposed to behave differently. I can't tell this for sure because there doesn't seem to be any explicit tests that enforce such behavior. Unfortunately DirectSolrSpellChecker also triggers some of this logic. Removing this extra logic around the "correctlySpelled" flag fixes the problem described here. If this somehow breaks expected (but not covered in unit test) behavior with FileBasedSpellchecker, we can handle that separately should someone speak up.
> Spellchecker always incorrectly spelled
> ---------------------------------------
>
> Key: SOLR-3457
> URL: https://issues.apache.org/jira/browse/SOLR-3457
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Environment: solr-spec 4.0.0.2012.05.15.11.42.06
> solr-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 11:42:06
> lucene-spec 4.0-SNAPSHOT
> lucene-impl 4.0-SNAPSHOT 1338601 - markus - 2012-05-15 10:51:02
> Reporter: Markus Jelsma
> Attachments: SOLR-3457-4.0-1.patch
>
>
> correctlySpelled is always false with default configuration, example config and example documents:
> http://localhost:8983/solr/collection1/browse?wt=xml&spellcheck.extendedResults=true&q=samsung
> {code}
> <lst name="spellcheck">
> <lst name="suggestions">
> <bool name="correctlySpelled">false</bool>
> </lst>
> </lst>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org