You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Davor Bonaci (JIRA)" <ji...@apache.org> on 2017/03/06 01:36:33 UTC
[jira] [Created] (BEAM-1628) Flink runner: logic around
--flinkMaster is error-prone
Davor Bonaci created BEAM-1628:
----------------------------------
Summary: Flink runner: logic around --flinkMaster is error-prone
Key: BEAM-1628
URL: https://issues.apache.org/jira/browse/BEAM-1628
Project: Beam
Issue Type: Bug
Components: runner-flink
Reporter: Davor Bonaci
Assignee: Aljoscha Krettek
Priority: Minor
The logic for handling {{--flinkMaster}} seems not particularly user-friendly.
https://github.com/apache/beam/blob/fbcde4cdc7d68de8734bf540c079b2747631a854/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkPipelineExecutionEnvironment.java#L132
{code}
if (masterUrl.equals("[local]")) {
} else if (masterUrl.equals("[collection]")) {
} else if (masterUrl.equals("[auto]")) {
} else if (masterUrl.matches(".*:\\d*")) {
} else {
// use auto.
}
{code}
The options are constructed with "auto" set as default.
I think we should do the following:
* I assume there's a default port for the Flink master. We should default to it.
* We should treat a string without a colon as a host name. (Not default to local execution.)
This is super easy fix, hopefully someone can pick it up quickly ;-)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)