You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Richard Evans (JIRA)" <ji...@apache.org> on 2010/03/29 11:56:27 UTC
[jira] Created: (FTPSERVER-361) Provide more information on command
execution to Ftplets - especially file created in STOU
Provide more information on command execution to Ftplets - especially file created in STOU
------------------------------------------------------------------------------------------
Key: FTPSERVER-361
URL: https://issues.apache.org/jira/browse/FTPSERVER-361
Project: FtpServer
Issue Type: Improvement
Components: Ftplets
Affects Versions: 1.0.4
Reporter: Richard Evans
To monitor file uploads, I can configure an Ftplet and override onUploadEnd and onUploadUniqueEnd in DefaultFtplet. However I cannot find a way to determine the real file that was written in the upload.
For a non-unique upload I can get the argument and resolve it against the working directory in the file system view; but this seems unnecessarily complex and does not for for unique uploads (STOU) because the random file name is not available.
Browsing the code I can see the file observer stuff, but these are non-public APIs and there can be only one observer at a time whilst I can have many independent Ftplets implementing the onUpload APIs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (FTPSERVER-361) Provide more information on
command execution to Ftplets - especially file created in STOU
Posted by Sai Pullabhotla <sa...@jmethods.com>.
I think this should have been taken care of with the
https://issues.apache.org/jira/browse/FTPSERVER-222. You might want to
try building from the trunk and see if this works out better.
Regards,
Sai Pullabhotla
On Mon, Mar 29, 2010 at 4:56 AM, Richard Evans (JIRA) <ji...@apache.org> wrote:
> Provide more information on command execution to Ftplets - especially file created in STOU
> ------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-361
> URL: https://issues.apache.org/jira/browse/FTPSERVER-361
> Project: FtpServer
> Issue Type: Improvement
> Components: Ftplets
> Affects Versions: 1.0.4
> Reporter: Richard Evans
>
>
> To monitor file uploads, I can configure an Ftplet and override onUploadEnd and onUploadUniqueEnd in DefaultFtplet. However I cannot find a way to determine the real file that was written in the upload.
>
> For a non-unique upload I can get the argument and resolve it against the working directory in the file system view; but this seems unnecessarily complex and does not for for unique uploads (STOU) because the random file name is not available.
>
> Browsing the code I can see the file observer stuff, but these are non-public APIs and there can be only one observer at a time whilst I can have many independent Ftplets implementing the onUpload APIs.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (FTPSERVER-361) Provide more information on
command execution to Ftplets - especially file created in STOU
Posted by "David Latorre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851302#action_12851302 ]
David Latorre commented on FTPSERVER-361:
-----------------------------------------
We can do this but my suggestion is that you do not rely on the provided DefaultFtpLet. In our case, we ended up 'cloning' DefaultFtpLet, but changing some method bodies / signatures in order to fit our needs and this is quite common a need for other users as well.
> Provide more information on command execution to Ftplets - especially file created in STOU
> ------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-361
> URL: https://issues.apache.org/jira/browse/FTPSERVER-361
> Project: FtpServer
> Issue Type: Improvement
> Components: Ftplets
> Affects Versions: 1.0.4
> Reporter: Richard Evans
>
> To monitor file uploads, I can configure an Ftplet and override onUploadEnd and onUploadUniqueEnd in DefaultFtplet. However I cannot find a way to determine the real file that was written in the upload.
> For a non-unique upload I can get the argument and resolve it against the working directory in the file system view; but this seems unnecessarily complex and does not for for unique uploads (STOU) because the random file name is not available.
> Browsing the code I can see the file observer stuff, but these are non-public APIs and there can be only one observer at a time whilst I can have many independent Ftplets implementing the onUpload APIs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-361) Provide more information on
command execution to Ftplets - especially file created in STOU
Posted by "Richard Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850872#action_12850872 ]
Richard Evans commented on FTPSERVER-361:
-----------------------------------------
I see - the reply would indicate the file that was stored, etc.
Can I suggest a new methods on DefaultFtpLet which are called with the reply object cast to the correct class for the command?
eg.
public FtpletResult onUploadEnd(FtpSession session, FtpRequest request, DataTransferFtpReply reply)
put I guess this would fail if the reply indicated some failure?
> Provide more information on command execution to Ftplets - especially file created in STOU
> ------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-361
> URL: https://issues.apache.org/jira/browse/FTPSERVER-361
> Project: FtpServer
> Issue Type: Improvement
> Components: Ftplets
> Affects Versions: 1.0.4
> Reporter: Richard Evans
>
> To monitor file uploads, I can configure an Ftplet and override onUploadEnd and onUploadUniqueEnd in DefaultFtplet. However I cannot find a way to determine the real file that was written in the upload.
> For a non-unique upload I can get the argument and resolve it against the working directory in the file system view; but this seems unnecessarily complex and does not for for unique uploads (STOU) because the random file name is not available.
> Browsing the code I can see the file observer stuff, but these are non-public APIs and there can be only one observer at a time whilst I can have many independent Ftplets implementing the onUpload APIs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-361) Provide more information on
command execution to Ftplets - especially file created in STOU
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850867#action_12850867 ]
Niklas Gustavsson commented on FTPSERVER-361:
---------------------------------------------
I think we have solved this in trunk (which will become 1.1.0) already. Have a look at the FileActionFtpReply class in particular.
> Provide more information on command execution to Ftplets - especially file created in STOU
> ------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-361
> URL: https://issues.apache.org/jira/browse/FTPSERVER-361
> Project: FtpServer
> Issue Type: Improvement
> Components: Ftplets
> Affects Versions: 1.0.4
> Reporter: Richard Evans
>
> To monitor file uploads, I can configure an Ftplet and override onUploadEnd and onUploadUniqueEnd in DefaultFtplet. However I cannot find a way to determine the real file that was written in the upload.
> For a non-unique upload I can get the argument and resolve it against the working directory in the file system view; but this seems unnecessarily complex and does not for for unique uploads (STOU) because the random file name is not available.
> Browsing the code I can see the file observer stuff, but these are non-public APIs and there can be only one observer at a time whilst I can have many independent Ftplets implementing the onUpload APIs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.