[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3889: [improve] [client] Group read/write response when jumping to the ordered executor

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #3889:
URL: https://github.com/apache/bookkeeper/pull/3889#discussion_r1155055313


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1341,7 +1349,10 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
 
         if (msg instanceof BookieProtocol.Response) {
             BookieProtocol.Response response = (BookieProtocol.Response) msg;
-            readV2Response(response);
+            if (!responses.offer(response)) {

Review Comment:
   Good point. I add a flag to enable this feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org