You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/13 09:29:23 UTC

[GitHub] markusthoemmes commented on issue #2593: Add BaseWsk class for Wsk and WskRest to inherit

markusthoemmes commented on issue #2593: Add BaseWsk class for Wsk and WskRest to inherit
URL: https://github.com/apache/incubator-openwhisk/pull/2593#issuecomment-329112018
 
 
   Generally looks okay. The issue I see with it: Without the other extension point (WskRest), we cannot be sure if the abstraction is okay. This is more or less just creating a trait out of the existing implementation. Would it make sense to provide `WskRest` as well or would that make the PR too big?
   
   I'm also wondering if we need the common base class or if we could just override the existing `Wsk` using rest based methods step by step while abstracting away helpers, that should not be surfaced because they correspond only to either CLI or REST.
   
   Does that make sense?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services