You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/10 17:28:26 UTC

[GitHub] [kafka] mimaison commented on a change in pull request #11560: KAFKA-7589: Allow configuring network threads per listener

mimaison commented on a change in pull request #11560:
URL: https://github.com/apache/kafka/pull/11560#discussion_r766857004



##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -841,16 +974,17 @@ private[kafka] class Processor(val id: Int,
     Option(metrics.metric(metrics.metricName("io-wait-ratio", MetricsGroup, metricTags))).fold(0.0)(m =>
       Math.min(m.metricValue.asInstanceOf[Double], 1.0))
   },
+    //TODO is this an issue if we change the metrics tags?

Review comment:
       I've pushed an update to keep all existing metric names.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org