You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by krichter722 <gi...@git.apache.org> on 2018/03/18 17:09:21 UTC

[GitHub] storm pull request #2594: storm-kafka: encapsulated Broker.host and port

GitHub user krichter722 opened a pull request:

    https://github.com/apache/storm/pull/2594

    storm-kafka: encapsulated Broker.host and port

    This satisfies the checkstyle check.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/krichter722/storm broker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2594
    
----
commit b4103806bb00d4c90b8fda71b559417c41af70bd
Author: Karl-Philipp Richter <kr...@...>
Date:   2018-03-18T15:33:43Z

    storm-kafka: encapsulated Broker.host and port

----


---

[GitHub] storm issue #2594: storm-kafka: encapsulated Broker.host and port

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2594
  
    I second @srdo, and we'd better to handle removal of storm-kafka sooner to avoid such case. 


---

[GitHub] storm issue #2594: storm-kafka: encapsulated Broker.host and port

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2594
  
    The changes look good, but I'm wondering whether it makes sense to make this kind of improvement. We're planning to remove storm-kafka from master soon, we're just waiting on a couple of other issues to resolve first https://issues.apache.org/jira/browse/STORM-2953. Unless storm-kafka ends up not getting removed, this change might end up not getting released.


---