You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (JIRA)" <ji...@apache.org> on 2011/05/03 22:25:03 UTC
[jira] [Created] (SOLR-2491) spellcheck.maxCollationTries breaks
when using FieldCollapsing
spellcheck.maxCollationTries breaks when using FieldCollapsing
--------------------------------------------------------------
Key: SOLR-2491
URL: https://issues.apache.org/jira/browse/SOLR-2491
Project: Solr
Issue Type: Bug
Components: spellchecker
Affects Versions: 4.0
Reporter: James Dyer
Priority: Minor
Fix For: 4.0
If specifying "spellcheck.maxCollationTries" and "group=true" on the same query, you never get any Spell Check Collations back. The problem is that SpellCheckCollator relies on ResponseBuilder.getToLog().get("hits") to see how many results each test query returns. When "group=true", the "toLog" isn't populated so SpellCheckCollator is unable to find a collation that can return results.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2491) spellcheck.maxCollationTries breaks
when using FieldCollapsing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045248#comment-13045248 ]
Robert Muir commented on SOLR-2491:
-----------------------------------
James: any opinion on this with regards to SOLR-2564?
I'm totally lost when it comes to grouping, but do you still think collation should use ungrouped queries or should we wait on SOLR-2564, which seems to suggest it can return this count... I could be confused here and haven't looked in detail though.
> spellcheck.maxCollationTries breaks when using FieldCollapsing
> --------------------------------------------------------------
>
> Key: SOLR-2491
> URL: https://issues.apache.org/jira/browse/SOLR-2491
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2491.patch
>
>
> If specifying "spellcheck.maxCollationTries" and "group=true" on the same query, you never get any Spell Check Collations back. The problem is that SpellCheckCollator relies on ResponseBuilder.getToLog().get("hits") to see how many results each test query returns. When "group=true", the "toLog" isn't populated so SpellCheckCollator is unable to find a collation that can return results.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2491) spellcheck.maxCollationTries breaks
when using FieldCollapsing
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-2491:
-----------------------------
Attachment: SOLR-2491.patch
This patch fixes the problem & includes a unit test. This patch simply removes the "group" parameter from any test queries prior to running them.
Note that the # of hits for each collation returned will always be the # of _ungrouped_ hits. This is consistent with the fact that FieldCollapsing is unable to tell us the number of grouped hits.
It is a bit disturbing to me how brittle getting the # of hits back via "toLog" has proven to be. If someone can point to a less breakable way to do this it would be appreciated.
> spellcheck.maxCollationTries breaks when using FieldCollapsing
> --------------------------------------------------------------
>
> Key: SOLR-2491
> URL: https://issues.apache.org/jira/browse/SOLR-2491
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2491.patch
>
>
> If specifying "spellcheck.maxCollationTries" and "group=true" on the same query, you never get any Spell Check Collations back. The problem is that SpellCheckCollator relies on ResponseBuilder.getToLog().get("hits") to see how many results each test query returns. When "group=true", the "toLog" isn't populated so SpellCheckCollator is unable to find a collation that can return results.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2491) spellcheck.maxCollationTries breaks
when using FieldCollapsing
Posted by "James Dyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045453#comment-13045453 ]
James Dyer commented on SOLR-2491:
----------------------------------
I think this issue can go separately from SOLR-2564 and have it use ungrouped queries. This little patch allows people to use both features in tandem now rather than waiting for later (for instance, I have an app in production using this patch now...) .
As a follow-up to SOLR-2564, it would be nice to give the user the option to return # of grouped hits. If the end-user is receiving groups as results and the app gives a message like "300 results (groups) returned", then in the case of a misspelled query, any "did-you-mean" message that includes # of hits would probably need to be consistent and give # groups rather than # documents. So this would be useful additional functionality, whenever we indeed get grouping that can return # groups...
Maybe a separate issue should be opened just for this, and it can be worked after SOLR-2564 goes in?
> spellcheck.maxCollationTries breaks when using FieldCollapsing
> --------------------------------------------------------------
>
> Key: SOLR-2491
> URL: https://issues.apache.org/jira/browse/SOLR-2491
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2491.patch
>
>
> If specifying "spellcheck.maxCollationTries" and "group=true" on the same query, you never get any Spell Check Collations back. The problem is that SpellCheckCollator relies on ResponseBuilder.getToLog().get("hits") to see how many results each test query returns. When "group=true", the "toLog" isn't populated so SpellCheckCollator is unable to find a collation that can return results.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2491) spellcheck.maxCollationTries breaks
when using FieldCollapsing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045458#comment-13045458 ]
Robert Muir commented on SOLR-2491:
-----------------------------------
James: sounds like a plan.
Lets try to get this one resolved and we can followup with the option (and maybe change default or whatever) when that makes sense.
I'll review the patch shortly.
> spellcheck.maxCollationTries breaks when using FieldCollapsing
> --------------------------------------------------------------
>
> Key: SOLR-2491
> URL: https://issues.apache.org/jira/browse/SOLR-2491
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2491.patch
>
>
> If specifying "spellcheck.maxCollationTries" and "group=true" on the same query, you never get any Spell Check Collations back. The problem is that SpellCheckCollator relies on ResponseBuilder.getToLog().get("hits") to see how many results each test query returns. When "group=true", the "toLog" isn't populated so SpellCheckCollator is unable to find a collation that can return results.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2491) spellcheck.maxCollationTries breaks
when using FieldCollapsing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved SOLR-2491.
-------------------------------
Resolution: Fixed
Assignee: Robert Muir
Committed revision 1133043.
Thanks James!
> spellcheck.maxCollationTries breaks when using FieldCollapsing
> --------------------------------------------------------------
>
> Key: SOLR-2491
> URL: https://issues.apache.org/jira/browse/SOLR-2491
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2491.patch
>
>
> If specifying "spellcheck.maxCollationTries" and "group=true" on the same query, you never get any Spell Check Collations back. The problem is that SpellCheckCollator relies on ResponseBuilder.getToLog().get("hits") to see how many results each test query returns. When "group=true", the "toLog" isn't populated so SpellCheckCollator is unable to find a collation that can return results.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org