[GitHub] [iceberg] openinx commented on a change in pull request #2294: Core: Support rewriting delete files.

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2294:
URL: https://github.com/apache/iceberg/pull/2294#discussion_r590008800



##########
File path: api/src/main/java/org/apache/iceberg/RewriteFiles.java
##########
@@ -38,8 +39,27 @@
    * Add a rewrite that replaces one set of files with another set that contains the same data.
    *
    * @param filesToDelete files that will be replaced (deleted), cannot be null or empty.
-   * @param filesToAdd files that will be added, cannot be null or empty.
+   * @param filesToAdd    files that will be added, cannot be null or empty.
    * @return this for method chaining
    */
-  RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile> filesToAdd);
+  default RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile> filesToAdd) {

Review comment:
       I think you want to expose this API for replacing equality deletions with positional deletions,  for me that seems like an internal usage we may don't have to define such a specific API for end users.  I prefer to expose the following common API to end users,  for our internal usage we could rewrite files based on that one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org