[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2033: fix outdated manifest version & use project.version instead

[GitBox <gi...@apache.org>]

javeme commented on code in PR #2033:
URL: https://github.com/apache/incubator-hugegraph/pull/2033#discussion_r1032270400


##########
hugegraph-core/src/main/java/org/apache/hugegraph/version/CoreVersion.java:
##########
@@ -41,6 +41,6 @@ public class CoreVersion {
     public static void check() {
         // Check version of hugegraph-common
         // TODO: why shall we check it? Update it if need
-        VersionUtil.check(CommonVersion.VERSION, "2.1.0", "2.2.0", CommonVersion.NAME);
+        VersionUtil.check(CommonVersion.VERSION, "1.0.0", "1.0.1", CommonVersion.NAME);

Review Comment:
   the right version is inclusive, `[1.0, 1.1)` is ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org