You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Anders Hammar <an...@hammar.net> on 2012/12/04 08:34:12 UTC
apache/maven-3 at Github
This git repo at Github mirrors the old Git repo. Is it possible to change
that to the new git repo, or should it be removed all together?
/Anders
Re: apache/maven-3 at Github
Posted by Mark Struberg <st...@yahoo.de>.
if the diff is included in the mail then that would be sufficient imo. But I'd rather ping back to board if this is fine.
If the mail is created with git-format-patch and later applied via git-am then this should be as fine as JIRA imo. Still a JIRA reference should be there for referencing in the release notes, etc.
My main point is that a hell lot of github forks have a pretty unclear provenance and a rather questionable quality :/
I really like github for some stuff, but nowadays it somehow looks like a dustbin which didn't get cleaned up since ages ;)
LieGrue,
strub
----- Original Message -----
> From: Kristian Rosenvold <kr...@gmail.com>
> To: Maven Developers List <de...@maven.apache.org>; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Wednesday, December 5, 2012 10:53 AM
> Subject: Re: apache/maven-3 at Github
>
> 2012/12/5 Mark Struberg <st...@yahoo.de>:
>> But to make this more clear, we will only accept pull changes if they come
> along with an identical JIRA with the diff. You also must make sure that you are
> the only one who has changed something in the contribution. It's way to easy
> to fake author Ids on github...
>>
>> The committer which applies the patch or signs off the pull request must
> make sure that all IP is cleared.
>
> We've been through this before ;)
>
> I understand that the important thing is that there's a clear record
> of authorship and a clear record of submission ?
>
> As far as I understand the pull request being sent to the dev@ list is
> a record of submission. It's a bit of a pity the
> actual diff isn't included in the pull request mail; I wonder why the
> asf script that dispatches these mails doesn't include fetch the
> actual diff ?
>
> As for clear record of authorship I have tended to assume that
> committer emails must clearly show an email address or a name that
> would match a name in a jira. As for /who/ that person is, we have
> never really known anyway. I am unsure if we should downright reject
> commits/pull requests that do not sufficiently identify the author,
> even if they reference a jira?
>
> Since I rebase and amend most submissions, I tend to add the details
> about the jira submitter to the extent they
> do not match the author info in git.
>
> As for the *actual* diff attached to a jira; do we really need those ?
> Wouldn't it be sufficient if the mail from pull included the diff ?
>
> Kristian
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: apache/maven-3 at Github
Posted by Kristian Rosenvold <kr...@gmail.com>.
2012/12/5 Mark Struberg <st...@yahoo.de>:
> But to make this more clear, we will only accept pull changes if they come along with an identical JIRA with the diff. You also must make sure that you are the only one who has changed something in the contribution. It's way to easy to fake author Ids on github...
>
> The committer which applies the patch or signs off the pull request must make sure that all IP is cleared.
We've been through this before ;)
I understand that the important thing is that there's a clear record
of authorship and a clear record of submission ?
As far as I understand the pull request being sent to the dev@ list is
a record of submission. It's a bit of a pity the
actual diff isn't included in the pull request mail; I wonder why the
asf script that dispatches these mails doesn't include fetch the
actual diff ?
As for clear record of authorship I have tended to assume that
committer emails must clearly show an email address or a name that
would match a name in a jira. As for /who/ that person is, we have
never really known anyway. I am unsure if we should downright reject
commits/pull requests that do not sufficiently identify the author,
even if they reference a jira?
Since I rebase and amend most submissions, I tend to add the details
about the jira submitter to the extent they
do not match the author info in git.
As for the *actual* diff attached to a jira; do we really need those ?
Wouldn't it be sufficient if the mail from pull included the diff ?
Kristian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: apache/maven-3 at Github
Posted by Mark Struberg <st...@yahoo.de>.
But to make this more clear, we will only accept pull changes if they come along with an identical JIRA with the diff. You also must make sure that you are the only one who has changed something in the contribution. It's way to easy to fake author Ids on github...
The committer which applies the patch or signs off the pull request must make sure that all IP is cleared.
Another reason for not having our cannonical repo on github - and even for having a cannonical repo at all - is that we do not like the the 'fork creeping' which we've seen on github quite often.
As example: There are quite some codehaus mojo projects which did move from codehaus svn to github. Almost all of them are dead dead dead in the meantime :(
Now what happened? It was obviously very easy to fork those projects and to fix their own problems. But most people didn't care about getting the bugfixes back to the 'main' git repo nor even to get feedback from the community. If you look at a few of those old codehaus mojo projects you will see that most of them have 25++ forks with changes (actually there are much more forks _without_ changes). Together with Fred Cooke I tried to grasp an idea what went wrong with the osxappbundle-maven-plugin. The result was that ALL of the forks on github are broken! People only fixed _their_ issue but always broke other scenarios! There was no single plugin which e.g. worked with OSX 1.5, 1.6 and 1.7 (was before 1.8 came out). Serious folks, thats Kindergarten and we don't like this in an ASF project!
LieGrue,
strub
----- Original Message -----
> From: Kristian Rosenvold <kr...@gmail.com>
> To: Maven Developers List <de...@maven.apache.org>
> Cc:
> Sent: Wednesday, December 5, 2012 9:47 AM
> Subject: Re: apache/maven-3 at Github
>
> Mirroring to make it available in mainstream channels is a Good Thing
> IMO. Pull requests are also nice.
>
> Git goes a long way to eradicate the "committer bit" barrier to
> contribution; anyone can fork and modify code
> at next to zero cost. Some will also contribute back. Pushing to
> github makes creating your own writeable fork
> as easy as pressing the "fork" button.
>
> Another interesting feature available by virtue of github is the
> network graph; look at
> https://github.com/apache/maven-surefire/network for an example. It
> actually keeps track
> of what the "community" is doing and if you're feeling social you
> can
> drop by someone else's
> fork, leave a comment - maybe even encourage them to complete their
> work and submit
> a patch!
>
> Kristian
>
> 2012/12/5 Jochen Wiedmann <jo...@gmail.com>:
>> What's Apache sources got to do at Github anywyays?
>>
>>
>>
>> On Tue, Dec 4, 2012 at 8:34 AM, Anders Hammar <an...@hammar.net>
> wrote:
>>
>>> This git repo at Github mirrors the old Git repo. Is it possible to
> change
>>> that to the new git repo, or should it be removed all together?
>>>
>>> /Anders
>>>
>>
>>
>>
>> --
>> The best argument for celibacy is that the clergy will sooner or later
>> become extinct.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: apache/maven-3 at Github
Posted by Kristian Rosenvold <kr...@gmail.com>.
Mirroring to make it available in mainstream channels is a Good Thing
IMO. Pull requests are also nice.
Git goes a long way to eradicate the "committer bit" barrier to
contribution; anyone can fork and modify code
at next to zero cost. Some will also contribute back. Pushing to
github makes creating your own writeable fork
as easy as pressing the "fork" button.
Another interesting feature available by virtue of github is the
network graph; look at
https://github.com/apache/maven-surefire/network for an example. It
actually keeps track
of what the "community" is doing and if you're feeling social you can
drop by someone else's
fork, leave a comment - maybe even encourage them to complete their
work and submit
a patch!
Kristian
2012/12/5 Jochen Wiedmann <jo...@gmail.com>:
> What's Apache sources got to do at Github anywyays?
>
>
>
> On Tue, Dec 4, 2012 at 8:34 AM, Anders Hammar <an...@hammar.net> wrote:
>
>> This git repo at Github mirrors the old Git repo. Is it possible to change
>> that to the new git repo, or should it be removed all together?
>>
>> /Anders
>>
>
>
>
> --
> The best argument for celibacy is that the clergy will sooner or later
> become extinct.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: apache/maven-3 at Github
Posted by Jochen Wiedmann <jo...@gmail.com>.
What's Apache sources got to do at Github anywyays?
On Tue, Dec 4, 2012 at 8:34 AM, Anders Hammar <an...@hammar.net> wrote:
> This git repo at Github mirrors the old Git repo. Is it possible to change
> that to the new git repo, or should it be removed all together?
>
> /Anders
>
--
The best argument for celibacy is that the clergy will sooner or later
become extinct.
Re: apache/maven-3 at Github
Posted by Olivier Lamy <ol...@apache.org>.
I created https://issues.apache.org/jira/browse/INFRA-5579
I wait as I cannot do it myself.
2012/12/4 Anders Hammar <an...@hammar.net>:
> This git repo at Github mirrors the old Git repo. Is it possible to change
> that to the new git repo, or should it be removed all together?
>
> /Anders
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org