[jira] [Commented] (IGNITE-9742) Illegal change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633122#comment-16633122 ] 

ASF GitHub Bot commented on IGNITE-9742:
----------------------------------------

GitHub user daradurvs opened a pull request:

    https://github.com/apache/ignite/pull/4875

    IGNITE-9742 Illegal change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daradurvs/ignite ignite-9742

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4875
    
----
commit eabe386acef14647e92ff36d2ffeb0b1ad642df2
Author: Vyacheslav Daradur <da...@...>
Date:   2018-09-29T21:07:04Z

    fixed

----


> Illegal change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-9742
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9742
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Vyacheslav Daradur
>            Assignee: Vyacheslav Daradur
>            Priority: Major
>              Labels: discovery
>             Fix For: 2.8
>
>
> The following code is called in {{GridDhtPartitionsExchangeFuture#onDone}}:
> {code}
> ((DiscoveryCustomEvent)firstDiscoEvt).customMessage(null);
> {code}
> That means a global instance of 'DiscoveryCustomEvent' is being
> mutated outside discovery-spi infrastructure. It also means that
> discovery listeners receive 'DiscoveryCustomEvent' with 'null' field
> instead of 'CustomMessage' which they may rely on.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)