You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/11 12:13:03 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
gaoyunhaii opened a new pull request #16784:
URL: https://github.com/apache/flink/pull/16784
## What is the purpose of the change
This PR fixes the issue that for the fully finished operator, if it has used the `OperatorCoordinator`, then when taking checkpoints, the `OperatorCoordinator` would report its state first and `PendingCheckpoint` would store an `OperatorState` for this operator. Then when we finally fulfill the `FullyFinishedOperatorState`, the current check that no `OperatorState` is stored would fail.
## Brief change log
We would relax the condition to allow if `OperatorState` is created, then it should not contains task state.
## Verifying this change
This change is tested via the added test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
}, {
"hash" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248",
"triggerID" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171)
* 5e680b91591be7309a59bdee1a8a52cbc61826bd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896776500
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1614804fc1b6652e8c55999fcbc0a15e31ca689c (Wed Aug 11 12:16:57 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1614804fc1b6652e8c55999fcbc0a15e31ca689c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916)
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
}, {
"hash" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248",
"triggerID" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"triggerType" : "PUSH"
}, {
"hash" : "7adceec744815f1d47e786f3dcf15902484730df",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22556",
"triggerID" : "7adceec744815f1d47e786f3dcf15902484730df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e680b91591be7309a59bdee1a8a52cbc61826bd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248)
* 7adceec744815f1d47e786f3dcf15902484730df Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22556)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1614804fc1b6652e8c55999fcbc0a15e31ca689c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916)
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #16784:
URL: https://github.com/apache/flink/pull/16784#discussion_r687578029
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -487,8 +487,8 @@ private void fulfillFullyFinishedOperatorStates() {
OperatorState operatorState =
operatorStates.get(operatorID.getGeneratedOperatorID());
checkState(
- operatorState == null,
- "There should be no states reported for fully finished operators");
+ operatorState == null || operatorState.getSubtaskStates().size() == 0,
Review comment:
nit: use `isEmpty`? move the check into the `operatorState` (as e.g. `hasSubtaskState` method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
}, {
"hash" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248",
"triggerID" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e680b91591be7309a59bdee1a8a52cbc61826bd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #16784:
URL: https://github.com/apache/flink/pull/16784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1614804fc1b6652e8c55999fcbc0a15e31ca689c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-898262943
That makes sense, thanks for the explanation @gaoyunhaii .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-898858918
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-898243366
Very thanks Roman @rkhachatryan for the review! I also agree with that it would also be solved by not taking snapshot for the coordinator whose tasks are fully finished, and it could reduce the overhead. But since we may have a re-consideration of if we want to snapshot and restore the finished operator coordinator in the next, perhaps we may first solve this issue in a simpler way~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1614804fc1b6652e8c55999fcbc0a15e31ca689c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1614804fc1b6652e8c55999fcbc0a15e31ca689c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
}, {
"hash" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248",
"triggerID" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"triggerType" : "PUSH"
}, {
"hash" : "7adceec744815f1d47e786f3dcf15902484730df",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22556",
"triggerID" : "7adceec744815f1d47e786f3dcf15902484730df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7adceec744815f1d47e786f3dcf15902484730df Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22556)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
}, {
"hash" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248",
"triggerID" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"triggerType" : "PUSH"
}, {
"hash" : "7adceec744815f1d47e786f3dcf15902484730df",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7adceec744815f1d47e786f3dcf15902484730df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e680b91591be7309a59bdee1a8a52cbc61826bd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22248)
* 7adceec744815f1d47e786f3dcf15902484730df UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-902808830
Very thanks Roman @rkhachatryan for the review! I'll merge the code~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16784:
URL: https://github.com/apache/flink/pull/16784#issuecomment-896788454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21916",
"triggerID" : "1614804fc1b6652e8c55999fcbc0a15e31ca689c",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062",
"triggerID" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"triggerType" : "PUSH"
}, {
"hash" : "04900c4ecb5bbe923198c7985dd07c0ae7832f40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171",
"triggerID" : "898858918",
"triggerType" : "MANUAL"
}, {
"hash" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e680b91591be7309a59bdee1a8a52cbc61826bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04900c4ecb5bbe923198c7985dd07c0ae7832f40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22062) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22171)
* 5e680b91591be7309a59bdee1a8a52cbc61826bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org