[jira] [Commented] (TS-306) enable log rotation for diags.log

["Daniel Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618906#comment-14618906 ] 

Daniel Xu commented on TS-306:
------------------------------

RFC on implementation plan:

- Create an independent base class with a lot of the functionality from LogFile (file rotation, byte tracking, timestamps, etc)
- Make LogFile inherit from the base class
- Make Diags use the base class to manage diags.log and traffic.out

A major benefit of this plan is that no code needs to be copied and pasted. It would also be very easy to add new basic functionality for log files. 
Drawbacks include more complexity and a mixing of what are two different types of logging systems. 

I'm mainly looking for design critique. 

> enable log rotation for diags.log
> ---------------------------------
>
>                 Key: TS-306
>                 URL: https://issues.apache.org/jira/browse/TS-306
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Logging
>            Reporter: Miles Libbey
>            Assignee: Daniel Xu
>              Labels: newbie
>             Fix For: 6.1.0
>
>
> (from yahoo bug 913896)
> Original description
> by Leif Hedstrom 3 years ago at 2006-12-04 12:42
> There might be reasons why this file might get filled up, e.g. libraries used by plugins producing output on STDOUT/STDERR. A few suggestions have been
> made, to somehow rotate traffic.out. One possible solution (suggested by Ryan) is to use cronolog (http://cronolog.org/), which seems like a fine idea.
> 		
>  
> Comment 1
>  by Joseph Rothrock  2 years ago at 2007-10-17 09:13:24
> Maybe consider rolling diags.log as well. -Feature enhancement.
> 		
> Comment 2
>  by Kevin Dalley 13 months ago at 2009-03-04 15:32:18
> When traffic.out gets filled up, error.log stops filing up, even though rotation is turned on. This is
> counter-intuitive.  Rotation does not control traffic.out, but a large traffic.out will stop error.log from being
> written.
> 		



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)