[GitHub] [iceberg] pvary commented on a diff in pull request #7571: Flink: Add retry limit for IcebergSource continuous split planning errors

["pvary (via GitHub)" <gi...@apache.org>]

pvary commented on code in PR #7571:
URL: https://github.com/apache/iceberg/pull/7571#discussion_r1189364519


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -458,7 +468,12 @@ public IcebergSource<T> build() {
       checkRequired();
       // Since builder already load the table, pass it to the source to avoid double loading
       return new IcebergSource<T>(
-          tableLoader, context, readerFunction, splitAssignerFactory, table);
+          tableLoader,
+          context,
+          readerFunction,
+          splitAssignerFactory,
+          flinkReadConf.planRetryNum(),

Review Comment:
   Thanks for the review @hililiwei!
   
   What I have seen is that all of the `ScanContext` configurations are passed down to the Iceberg scan. This one is a Flink only configuration and we do not have to pass that down there. With that in mind, do you still think that `planRetryNum` belongs there? No strong opinions here, just feels a bit strange.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org